From nobody Sat May 4 18:11:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1569233005; cv=none; d=zoho.com; s=zohoarc; b=lmTYRIjEpr5EmutoU1533e+WgPXNqNRtDzukN/LrYj8JELznvFDLiEmWycra/ZVXJGK1OZ6XtSe9eK4KcXJoY1J/fo78SXHLaUvEGZLuJcP3+6aWKlj5nbSvQOy/K2i8WrClDOIqm+USU9JTDOvtxXYseWZf5LJek/tcMUi18Zw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569233005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=nWLuiAdZhFdyAL9x04PTmftqHN59Ge28eeBL54jlyRc=; b=Gre1oc23ACpldmr4PZhHzq1THLoZHfq4UUa94LG1utTkJ0aM1Y/4w5xAcKD1Pa7jm4JI6Pu/NBb23SzHIs1yzZJIHk86oQSmXjFCGcQtu3jV7CQ2fH3jlWUzoXoNTx38YxiIiiYmvTZ4vsmk8J2zmkzqLAIjCd2kVwUruQGu4Es= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1569233005687460.9257427073924; Mon, 23 Sep 2019 03:03:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5EBD418CB8ED; Mon, 23 Sep 2019 10:03:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3924F6012D; Mon, 23 Sep 2019 10:03:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E5BD41803518; Mon, 23 Sep 2019 10:03:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8NA3MYj023563 for ; Mon, 23 Sep 2019 06:03:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id C95F35DC18; Mon, 23 Sep 2019 10:03:22 +0000 (UTC) Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C40565DAAC for ; Mon, 23 Sep 2019 10:03:17 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D272F2CE955 for ; Mon, 23 Sep 2019 10:03:13 +0000 (UTC) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 03:03:13 -0700 Received: from zly-optiplex-9020.bj.intel.com ([10.238.135.151]) by orsmga005.jf.intel.com with ESMTP; 23 Sep 2019 03:03:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="363580995" From: Luyao Zhong To: libvir-list@redhat.com Date: Mon, 23 Sep 2019 18:06:22 +0800 Message-Id: <1569233182-21261-1-git-send-email-luyao.zhong@intel.com> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 238 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 23 Sep 2019 10:03:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 23 Sep 2019 10:03:14 +0000 (UTC) for IP:'134.134.136.20' DOMAIN:'mga02.intel.com' HELO:'mga02.intel.com' FROM:'luyao.zhong@intel.com' RCPT:'' X-RedHat-Spam-Score: -2.3 (RCVD_IN_DNSWL_MED, SPF_HELO_NONE, SPF_PASS) 134.134.136.20 mga02.intel.com 134.134.136.20 mga02.intel.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.29 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Luyao Zhong Subject: [libvirt] [PATCH] clarify the xml example for NVDIMM more clealy X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Mon, 23 Sep 2019 10:03:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The NVDIMM backend file can be a normal file or a real device file, Current xml example and explainations may mislead users. So add more info about the NVDIMM related elements and update the xml examples. Signed-off-by: Luyao Zhong Reviewed-by: Michal Privoznik and pushed. --- docs/formatdomain.html.in | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 86a5261..556a39f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -8533,7 +8533,6 @@ qemu-kvm -net nic,model=3D? /dev/null <memory model=3D'nvdimm'> <source> <path>/tmp/nvdimm</path> - <alignsize unit=3D'KiB'>2048</alignsize> </source> <target> <size unit=3D'KiB'>524288</size> @@ -8544,9 +8543,10 @@ qemu-kvm -net nic,model=3D? /dev/null <readonly/> </target> </memory> - <memory model=3D'nvdimm'> + <memory model=3D'nvdimm' access=3D'shared'> <source> <path>/dev/dax0.0</path> + <alignsize unit=3D'KiB'>2048</alignsize> <pmem/> </source> <target> @@ -8580,6 +8580,8 @@ qemu-kvm -net nic,model=3D? /dev/null module basis. Values are the same as Memory Backing: shared and private. + For nvdimm model, if using real NVDIMM DAX device as + backend, shared is required.

=20 @@ -8643,7 +8645,8 @@ qemu-kvm -net nic,model=3D? /dev/null alignment used to mmap the address range for the backend path. If not supplied the host page size is use= d. For example, to mmap a real NVDIMM device a 2M-aligned page = may - be required. + be required, and host page size is 4KB, then we need to set = this + element to 2MB. Since 5.0.0

--=20 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list