From nobody Mon Apr 29 12:41:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561462949; cv=none; d=zoho.com; s=zohoarc; b=IQGqwLbrX//qo0t3kYQx8y++Op096nxGlG8w6WjoibxVnomXjk9+PQMX33a8QjgdtYSlzK7blRBSnyI2/2JGEiyJNRoePlV9gy4ePZLyXY052w/EIEwqVLksClkFyvxERpcox71+MApEkhoQMnKqViUdowFtrAmVDtJNU9rKs7s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561462949; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=BXM4h21wXCKjNxou4NGhmHDlMtiVWB5liKkRG5711K4=; b=cQv6RTHEPF2Ibrg2c+Hsdb8fXh8dDSM+y+jW5I1983NN5XPi8Vwb/Ww/Ru03vCiFojiA6Gl8yD7Ryg4sIKbw/uXvJQSUacGpsWfH8ZKhJoPEr6M1b0DKplXH73acOy98DnOSVGvvbjuoOWGs2mr/f34+FuCS6Q+vblhZeQOxng4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561462949406164.54319828228233; Tue, 25 Jun 2019 04:42:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F71D309264F; Tue, 25 Jun 2019 11:42:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D10495D9D5; Tue, 25 Jun 2019 11:42:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3BEA21806B18; Tue, 25 Jun 2019 11:42:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5PBgMuf003705 for ; Tue, 25 Jun 2019 07:42:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 31CB5600CD; Tue, 25 Jun 2019 11:42:22 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B2DE600C7 for ; Tue, 25 Jun 2019 11:42:19 +0000 (UTC) Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.70.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1C8F87620 for ; Tue, 25 Jun 2019 11:41:43 +0000 (UTC) Received: from yili?winhong.com (unknown [192.168.167.204]) by regular1.263xmail.com (Postfix) with ESMTP id 75B3020C for ; Tue, 25 Jun 2019 19:41:33 +0800 (CST) Received: from localhost.localdomain (unknown [14.18.236.70]) by smtp.263.net (postfix) whith ESMTP id P19190T140411307804416S1561462886432045_; Tue, 25 Jun 2019 19:41:32 +0800 (CST) X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: yili@winhong.com X-SENDER: yili@winhong.com X-LOGIN-NAME: yili@winhong.com X-FST-TO: libvir-list@redhat.com X-SENDER-IP: 14.18.236.70 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Yi Li To: libvir-list@redhat.com Date: Tue, 25 Jun 2019 19:41:25 +0800 Message-Id: <1561462885-2594-1-git-send-email-yili@winhong.com> X-Greylist: Sender passed SPF test, ACL 242 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 25 Jun 2019 11:42:10 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 25 Jun 2019 11:42:10 +0000 (UTC) for IP:'211.150.70.201' DOMAIN:'regular1.263xmail.com' HELO:'regular1.263xmail.com' FROM:'yili@winhong.com' RCPT:'' X-RedHat-Spam-Score: -0.009 (RCVD_IN_DNSWL_NONE, SPF_HELO_NONE) 211.150.70.201 regular1.263xmail.com 211.150.70.201 regular1.263xmail.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com, yili@winhong.com Subject: [libvirt] [PATCH] storage: omit comma for ceph mon hosts to librados X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 25 Jun 2019 11:42:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Silly mistakes omit the comma for multiple ipaddr Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0 Signed-off-by: Yi Li Reviewed-by: J=C3=A1n Tomko --- src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backen= d_rbd.c index bd6e3d5..315bef2 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -272,10 +272,10 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRB= DStatePtr ptr, const char *incFormat; if (virSocketAddrNumericFamily(source->hosts[i].name) =3D=3D A= F_INET6) { /* IPv6 address must be escaped in brackets on the cmd lin= e */ - incFormat =3D "[%s]:%d"; + incFormat =3D "[%s]:%d,"; } else { /* listenAddress is a hostname or IPv4 */ - incFormat =3D "%s:%d"; + incFormat =3D "%s:%d,"; } virBufferAsprintf(&mon_host, incFormat, source->hosts[i].name, --=20 2.7.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list