[libvirt] [PATCH] storage: omit comma for ceph mon hosts to librados

Yi Li posted 1 patch 4 years, 9 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1561462885-2594-1-git-send-email-yili@winhong.com
src/storage/storage_backend_rbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[libvirt] [PATCH] storage: omit comma for ceph mon hosts to librados
Posted by Yi Li 4 years, 9 months ago
Silly mistakes omit the comma for multiple ipaddr
Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0

Signed-off-by: Yi Li <yili@winhong.com>
---
 src/storage/storage_backend_rbd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
index bd6e3d5..315bef2 100644
--- a/src/storage/storage_backend_rbd.c
+++ b/src/storage/storage_backend_rbd.c
@@ -272,10 +272,10 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr,
             const char *incFormat;
             if (virSocketAddrNumericFamily(source->hosts[i].name) == AF_INET6) {
                 /* IPv6 address must be escaped in brackets on the cmd line */
-                incFormat = "[%s]:%d";
+                incFormat = "[%s]:%d,";
             } else {
                 /* listenAddress is a hostname or IPv4 */
-                incFormat = "%s:%d";
+                incFormat = "%s:%d,";
             }
             virBufferAsprintf(&mon_host, incFormat,
                               source->hosts[i].name,
-- 
2.7.5



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] storage: omit comma for ceph mon hosts to librados
Posted by Daniel P. Berrangé 4 years, 9 months ago
Shouldn't the $SUBJECT be  "add missing comma" not "omit comma",
since you are adding a missing comma here.

On Tue, Jun 25, 2019 at 07:41:25PM +0800, Yi Li wrote:
> Silly mistakes omit the comma for multiple ipaddr
> Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0
> 
> Signed-off-by: Yi Li <yili@winhong.com>
> ---
>  src/storage/storage_backend_rbd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
> index bd6e3d5..315bef2 100644
> --- a/src/storage/storage_backend_rbd.c
> +++ b/src/storage/storage_backend_rbd.c
> @@ -272,10 +272,10 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr,
>              const char *incFormat;
>              if (virSocketAddrNumericFamily(source->hosts[i].name) == AF_INET6) {
>                  /* IPv6 address must be escaped in brackets on the cmd line */
> -                incFormat = "[%s]:%d";
> +                incFormat = "[%s]:%d,";
>              } else {
>                  /* listenAddress is a hostname or IPv4 */
> -                incFormat = "%s:%d";
> +                incFormat = "%s:%d,";
>              }
>              virBufferAsprintf(&mon_host, incFormat,
>                                source->hosts[i].name,

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] storage: omit comma for ceph mon hosts to librados
Posted by Ján Tomko 4 years, 9 months ago
s/omit/fix omitted/

On Tue, Jun 25, 2019 at 07:41:25PM +0800, Yi Li wrote:
>Silly mistakes omit the comma for multiple ipaddr
>Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0
>
>Signed-off-by: Yi Li <yili@winhong.com>
>---
> src/storage/storage_backend_rbd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list