From nobody Mon May 6 21:16:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1556099836; cv=none; d=zoho.com; s=zohoarc; b=ZCGzVs3viQmgn498j7jL0rOUUkLYyIVugd6JF/boS9HNs/rx8wNguL+TCoLDKT5JWVkNxWmBZVWmrrZjnNFTLr8ZrKphTocj5g2tc5WMsf4TRLkaHpN95iTEoexxd9e6LxfA+kpxQjsbjly8lX8xFvnmMIm9LL91nD/OxXfxpc0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556099836; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=JemLFieMAO2x+ZAT0HzzGDbRwY6zpXsk1Z/3hCKAYFQ=; b=HV6Y6NcI2P+PV8ps+37BEMfmRHsWBIebfe790II1XGksPMaaO9V1liE/KJdWSyYkemPNciEauO5WrOJGUmlQ9B/mxSj8Rxjtlt9+Lc99BNG4pjKuN6E42KOjELjzEMVNmODdJetxxh19H0fcpOhDuaURZOKrWd8lvfMiIBh7atc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1556099836048886.540368784536; Wed, 24 Apr 2019 02:57:16 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E09DD308FED5; Wed, 24 Apr 2019 09:57:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83576272B8; Wed, 24 Apr 2019 09:57:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 77F0F41F3D; Wed, 24 Apr 2019 09:57:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3O9v7e1006960 for ; Wed, 24 Apr 2019 05:57:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id CDD421001F52; Wed, 24 Apr 2019 09:57:07 +0000 (UTC) Received: from mx1.redhat.com (ext-mx14.extmail.prod.ext.phx2.redhat.com [10.5.110.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8EFF1001E98 for ; Wed, 24 Apr 2019 09:57:05 +0000 (UTC) Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99D5130BCE58 for ; Wed, 24 Apr 2019 09:57:03 +0000 (UTC) Received: from [10.94.3.220] (helo=dim-vz7.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1hJEeC-0006xa-Ph for libvir-list@redhat.com; Wed, 24 Apr 2019 12:57:01 +0300 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Date: Wed, 24 Apr 2019 12:56:58 +0300 Message-Id: <1556099818-488433-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Greylist: Sender passed SPF test, ACL 242 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 24 Apr 2019 09:57:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 24 Apr 2019 09:57:04 +0000 (UTC) for IP:'185.231.240.75' DOMAIN:'relay.sw.ru' HELO:'relay.sw.ru' FROM:'nshirokovskiy@virtuozzo.com' RCPT:'' X-RedHat-Spam-Score: -0.001 (SPF_PASS) 185.231.240.75 relay.sw.ru 185.231.240.75 relay.sw.ru X-Scanned-By: MIMEDefang 2.84 on 10.5.110.43 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] conf: add cpu check attribute to ABI check X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 24 Apr 2019 09:57:15 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Different check values is not ABI compatible. For example if on migration we change 'full' to 'partial' then guest cpu on destination can be different. Signed-off-by: Nikolay Shirokovskiy Reviewed-by: Jiri Denemark --- src/conf/cpu_conf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 33c8b99..bd2beab 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -894,6 +894,13 @@ virCPUDefIsEqual(virCPUDefPtr src, goto cleanup; } =20 + if (src->check !=3D dst->check) { + MISMATCH(_("Target CPU check %s does not match source %s"), + virCPUCheckTypeToString(dst->check), + virCPUCheckTypeToString(src->check)); + goto cleanup; + } + if (src->arch !=3D dst->arch) { MISMATCH(_("Target CPU arch %s does not match source %s"), virArchToString(dst->arch), --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list