From nobody Fri Mar 29 11:39:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555319574; cv=none; d=zoho.com; s=zohoarc; b=B6T6Quy1W1p4EFboBZEqg3ZkOmB7H2DrNoSlQEJOGAuYvg38bQxod8FWixBwiysWHW6F1ivKICeLm4zS5PFgCp1UkRe7PtAFWd8TgK14fwfXEfi0sh1l1WOK+n8/e2sXUm2r5BqKw3aCfEorAgnb9jPSudeNmnTAiw/gOryVpE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555319574; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=cmFiFwrcGQsxy7bf7Nq7wEix8mKpUTi1VoWieB96jfk=; b=De2XlhyPASeE5fMCHtuW/VJ3MN6ehFWMu84+CJW9z1TZtEVX3Rv77jsmr/hD/orVpDLHilHWv/5pBzVNmbv2l2giRBIynxdGS6nMpeMUorGz/eys8j1Nva9KZH4dEWvoQnCmTj10ESfoASaTz3CNBiIADPyxZVVMgAT88QNvWdE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1555319574627882.1207740649314; Mon, 15 Apr 2019 02:12:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6021186674; Mon, 15 Apr 2019 09:12:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68215108F854; Mon, 15 Apr 2019 09:12:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2E76C181AC42; Mon, 15 Apr 2019 09:12:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3CGBVuC007733 for ; Fri, 12 Apr 2019 12:11:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id F3C1D19747; Fri, 12 Apr 2019 16:11:30 +0000 (UTC) Received: from mx1.redhat.com (ext-mx13.extmail.prod.ext.phx2.redhat.com [10.5.110.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE92D19C65 for ; Fri, 12 Apr 2019 16:11:28 +0000 (UTC) Received: from zimbra.eo.pl (zimbra.eo.pl [217.17.46.141]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CA943082129 for ; Fri, 12 Apr 2019 16:11:10 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mailfe2.internal (Postfix) with ESMTP id 4C50988335; Fri, 12 Apr 2019 18:11:00 +0200 (CEST) Received: from zimbra.eo.pl ([127.0.0.1]) by localhost (mailfe2.internal [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eSb57m_LeyOE; Fri, 12 Apr 2019 18:11:00 +0200 (CEST) Received: from kvm221.tbg.eo.pl (gnl93.internetdsl.tpnet.pl [83.3.89.93]) by mailfe2.internal (Postfix) with ESMTPSA id 1426788253; Fri, 12 Apr 2019 18:11:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailfe2.internal From: Adrian Brzezinski To: libvir-list@redhat.com Date: Fri, 12 Apr 2019 18:10:49 +0200 Message-Id: <1555085449-1835-1-git-send-email-adrian.brzezinski@eo.pl> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 216 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 12 Apr 2019 16:11:19 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 12 Apr 2019 16:11:19 +0000 (UTC) for IP:'217.17.46.141' DOMAIN:'zimbra.eo.pl' HELO:'zimbra.eo.pl' FROM:'adrian.brzezinski@eo.pl' RCPT:'' X-RedHat-Spam-Score: -0.01 (RCVD_IN_DNSWL_NONE) 217.17.46.141 zimbra.eo.pl 217.17.46.141 zimbra.eo.pl X-Scanned-By: MIMEDefang 2.84 on 10.5.110.42 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Mon, 15 Apr 2019 05:12:44 -0400 Cc: Adrian Brzezinski , Adrian Brzezinski Subject: [libvirt] [PATCH] rpc: Segfaults and memory leak in virNetTLSContextNew function X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 15 Apr 2019 09:12:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Failed new gnutls context allocations in virNetTLSContextNew function results in double free and segfault. Occasional memory leaks may also occur. You can read detailed description at: https://bugzilla.redhat.com/show_bug.cgi?id=3D1699062 Signed-off-by: Adrian Brzezinski --- docs/news.xml | 10 ++++++++++ src/rpc/virnettlscontext.c | 6 ++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 21807f2..f6157ec 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -350,6 +350,16 @@
+ rpc: Segfaults and memory leak in virNetTLSContextNew function + + + Failed new gnutls context allocations in virNetTLSContextNew fun= ction + results in double free and segfault. Occasional memory leaks may= also + occur. + + + + qemu: Use CAP_DAC_OVERRIDE during QEMU capabilities probing diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 72e9ed9..8f6ec8f 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -703,14 +703,14 @@ static virNetTLSContextPtr virNetTLSContextNew(const = char *cacert, return NULL; =20 if (VIR_STRDUP(ctxt->priority, priority) < 0) - goto error; + goto ctxt_init_error; =20 err =3D gnutls_certificate_allocate_credentials(&ctxt->x509cred); if (err) { virReportError(VIR_ERR_SYSTEM_ERROR, _("Unable to allocate x509 credentials: %s"), gnutls_strerror(err)); - goto error; + goto ctxt_init_error; } =20 if (sanityCheckCert && @@ -759,6 +759,8 @@ static virNetTLSContextPtr virNetTLSContextNew(const ch= ar *cacert, if (isServer) gnutls_dh_params_deinit(ctxt->dhParams); gnutls_certificate_free_credentials(ctxt->x509cred); + ctxt_init_error: + if (ctxt->priority) VIR_FREE(ctxt->priority); VIR_FREE(ctxt); return NULL; } --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list