From nobody Sun May 5 07:44:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1548946571368213.7725681067783; Thu, 31 Jan 2019 06:56:11 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 236E113A98; Thu, 31 Jan 2019 14:56:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76C865C636; Thu, 31 Jan 2019 14:56:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EA22A3F602; Thu, 31 Jan 2019 14:56:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0VEu4KU030986 for ; Thu, 31 Jan 2019 09:56:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id 282AF1834A; Thu, 31 Jan 2019 14:56:04 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A41B91710F; Thu, 31 Jan 2019 14:56:00 +0000 (UTC) Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C905B87648; Thu, 31 Jan 2019 14:55:58 +0000 (UTC) Received: from DGGEML403-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id 0F28037FD3A2FF8E8440; Thu, 31 Jan 2019 22:55:51 +0800 (CST) Received: from localhost.localdomain (10.175.104.211) by DGGEML403-HUB.china.huawei.com (10.3.17.33) with Microsoft SMTP Server id 14.3.408.0; Thu, 31 Jan 2019 22:55:41 +0800 From: Jie Wang To: Date: Thu, 31 Jan 2019 20:50:31 +0800 Message-ID: <1548939031-64804-1-git-send-email-wangjie88@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.104.211] X-CFilter-Loop: Reflected X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 216 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 31 Jan 2019 14:55:59 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 31 Jan 2019 14:55:59 +0000 (UTC) for IP:'45.249.212.188' DOMAIN:'szxga02-in.huawei.com' HELO:'huawei.com' FROM:'wangjie88@huawei.com' RCPT:'' X-RedHat-Spam-Score: -0.702 (RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS) 45.249.212.188 szxga02-in.huawei.com 45.249.212.188 szxga02-in.huawei.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: wangjie88@huawei.com, wu.wubin@huawei.com, eric.fangyi@huawei.com Subject: [libvirt] [PATCH] conf: Remove iothreads restriction in virDomainDefCheckABIStabilityFlags X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 31 Jan 2019 14:56:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The number of iothreads is not part of the vm state sent during migration, nor exposed to the guest ABI, so this restriction is a mistaken in libvirt. Let's remove that bit of code. Signed-off-by: Jie Wang --- src/conf/domain_conf.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ae8fb5a501..ac4eeaec5e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22927,14 +22927,6 @@ virDomainDefCheckABIStabilityFlags(virDomainDefPtr= src, if (!virDomainDefVcpuCheckAbiStability(src, dst)) goto error; =20 - if (src->niothreadids !=3D dst->niothreadids) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain iothreads count %zu does not " - "match source %zu"), - dst->niothreadids, src->niothreadids); - goto error; - } - if (src->os.type !=3D dst->os.type) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target domain OS type %s does not match source %= s"), --=20 2.16.2.windows.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list