From nobody Sat Feb 7 06:20:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=virtuozzo.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1545906140179410.0098068776741; Thu, 27 Dec 2018 02:22:20 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C28D88E54; Thu, 27 Dec 2018 10:22:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E28105DA9A; Thu, 27 Dec 2018 10:22:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 992F23F602; Thu, 27 Dec 2018 10:22:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id wBRALl6k028142 for ; Thu, 27 Dec 2018 05:21:47 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8D71860C6D; Thu, 27 Dec 2018 10:21:47 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CED1C60C6B; Thu, 27 Dec 2018 10:21:44 +0000 (UTC) Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0D1F7FDEB; Thu, 27 Dec 2018 10:21:42 +0000 (UTC) Received: from [10.94.3.220] (helo=dim-vz7.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gcSnN-0003jg-2o; Thu, 27 Dec 2018 13:21:41 +0300 From: Nikolay Shirokovskiy To: libvir-list@redhat.com Date: Thu, 27 Dec 2018 13:20:49 +0300 Message-Id: <1545906052-101494-8-git-send-email-nshirokovskiy@virtuozzo.com> In-Reply-To: <1545906052-101494-1-git-send-email-nshirokovskiy@virtuozzo.com> References: <1545906052-101494-1-git-send-email-nshirokovskiy@virtuozzo.com> X-Greylist: Sender passed SPF test, ACL 238 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Dec 2018 10:21:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Dec 2018 10:21:43 +0000 (UTC) for IP:'185.231.240.75' DOMAIN:'relay.sw.ru' HELO:'relay.sw.ru' FROM:'nshirokovskiy@virtuozzo.com' RCPT:'' X-RedHat-Spam-Score: -0.001 (SPF_PASS) 185.231.240.75 relay.sw.ru 185.231.240.75 relay.sw.ru X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 07/10] qemu: disable internal snapshot of readonly disk X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 27 Dec 2018 10:22:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Now in case of active domain such a snapshot will complete successfully but disk will not have a correspondent internal snapshot as qemu will not make one. In case of inactive domain operation will finish successfully too but disk snapshot will be done. Let's disable such a snapshot because as described above in case of active domain it is not possible now and in both cases it does not make much sense. We recently disable external snapshot of readonly disk too in [1]. [1] 067aad26b - qemu: disable external snapshot of readonly disk Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c6fba1a..506d8ab 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14811,6 +14811,13 @@ qemuDomainSnapshotPrepareDiskInternal(virDomainDis= kDefPtr disk, { int actualType; =20 + if (disk->src->readonly) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("internal snapshot for readonly disk %s " + "is not supported"), disk->dst); + return -1; + } + /* active disks are handled by qemu itself so no need to worry about t= hose */ if (active) return 0; --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list