From nobody Sun Feb 8 15:47:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1532175033184658.8799959395456; Sat, 21 Jul 2018 05:10:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62AF987644; Sat, 21 Jul 2018 12:10:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 227E55C20D; Sat, 21 Jul 2018 12:10:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D0A051841C5D; Sat, 21 Jul 2018 12:10:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6LC8BMe016366 for ; Sat, 21 Jul 2018 08:08:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id A3B442015E43; Sat, 21 Jul 2018 12:08:11 +0000 (UTC) Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 989E42015E42 for ; Sat, 21 Jul 2018 12:08:07 +0000 (UTC) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35BE83082A2E for ; Sat, 21 Jul 2018 12:07:57 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id f1-v6so8956515pgq.12 for ; Sat, 21 Jul 2018 05:07:57 -0700 (PDT) Received: from centos.localdomain ([42.106.1.69]) by smtp.gmail.com with ESMTPSA id s16-v6sm5861694pfm.114.2018.07.21.05.07.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 05:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=+OcS+3H6Z9W2Hml2rQOYhyeKSjvX/Q4ErTlGwNOtOeA=; b=oqeYFzsNMWdnb5pMz6wqEKgPUJw7a7g/rKUvA7rYN8Xofuthi8TU6+bFKq3qwq0pPq rervWWi+g7LIQHBnPL1rBfm04aohUEw7llZXCX/s9IMqwkuBS0QCIEbnoFEwJRp65Sbt 2vkpA46Iw2BnskMM0XrIsHKSkhFmJnXekvglFFMXOMm0DLgBrV4vuKCyoeBB7mQAem3U tuxICo+WvTPp369Oz/BH/gy0eOMCGqS0kLYt8QTVN6JPY78d/8UOumL9EqDk8QDXjdZo mO8PV3qZwuK1a7ZxZimLtJxActXbDZootXieQJz3/Wj51kgFLKNyilVWN3yIdMDrCZqk Hzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=+OcS+3H6Z9W2Hml2rQOYhyeKSjvX/Q4ErTlGwNOtOeA=; b=d1FQZkTAgyZNan6V3ZDjbDOntqmcJAW0+7haHoMX+P7yEJrZiHwIQkqpZty9mkx/MP KDck7Atv23WXwOy6gz39nzLUEIrd01urrIgSI/OksW0+yeJILzfc7zV1BCblH/w9wnp2 u9+OSYGyF4WGxzvfhkP6ZXFiWLdQ5Vi616ynsCBxQv90+wor6AVpVZsO71yngdItYDWb XrhdXxtS16v77JsZ3XDbCHNVPv1vYsqkg/QesZaqI2dg6ggGeOXfIs/E4+JCAq+kUYWN qgVTug1WD+vNeAPAcUb2o4ehqV3qj3ajjqKp3n6jEarupTQ9JGxWNnTCqxuUiVWcd5+8 oyNg== X-Gm-Message-State: AOUpUlGjUFhnzoG+AFo6sT5PW4W7YEKVQoM2tjvljtZalazkPW1jInmK HFoQfXxkMIll60NQ7aYUVEo467IC X-Google-Smtp-Source: AAOMgpdjOEUBPT8URddjvV6JunIQgfXf4QgY2JNsCDWbMbs9fbmEpzU6tbBkZnZEQNN1EU+Yjtl+Qg== X-Received: by 2002:a62:3545:: with SMTP id c66-v6mr5833193pfa.63.1532174876416; Sat, 21 Jul 2018 05:07:56 -0700 (PDT) From: Sukrit Bhatnagar To: libvir-list@redhat.com Date: Sat, 21 Jul 2018 17:36:46 +0530 Message-Id: <1532174832-21644-15-git-send-email-skrtbhtngr@gmail.com> In-Reply-To: <1532174832-21644-1-git-send-email-skrtbhtngr@gmail.com> References: <1532174832-21644-1-git-send-email-skrtbhtngr@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 21 Jul 2018 12:07:57 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Sat, 21 Jul 2018 12:07:57 +0000 (UTC) for IP:'209.85.215.173' DOMAIN:'mail-pg1-f173.google.com' HELO:'mail-pg1-f173.google.com' FROM:'skrtbhtngr@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.301 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, SPF_PASS, T_DKIM_INVALID) 209.85.215.173 mail-pg1-f173.google.com 209.85.215.173 mail-pg1-f173.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v1 14/40] util: firewall: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sat, 21 Jul 2018 12:10:32 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in src/util/viralloc.h, define a new wrapper around an existing cleanup function which will be called when a variable declared with VIR_AUTOPTR macro goes out of scope. Also, drop the redundant viralloc.h include, since that has moved from the source module into the header. When a variable of type virFirewallPtr is declared using VIR_AUTOPTR, the function virFirewallFree will be run automatically on it when it goes out of scope. Signed-off-by: Sukrit Bhatnagar Reviewed-by: Erik Skultety --- src/util/virfirewall.c | 1 - src/util/virfirewall.h | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 10c370a..dfd792f 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -27,7 +27,6 @@ =20 #include =20 -#include "viralloc.h" #include "virfirewallpriv.h" #include "virerror.h" #include "virutil.h" diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h index b04ab48..e024e88 100644 --- a/src/util/virfirewall.h +++ b/src/util/virfirewall.h @@ -25,6 +25,7 @@ # define __VIR_FIREWALL_H__ =20 # include "internal.h" +# include "viralloc.h" =20 typedef struct _virFirewall virFirewall; typedef virFirewall *virFirewallPtr; @@ -116,4 +117,6 @@ int virFirewallApply(virFirewallPtr firewall); =20 void virFirewallSetLockOverride(bool avoid); =20 +VIR_DEFINE_AUTOPTR_FUNC(virFirewall, virFirewallFree) + #endif /* __VIR_FIREWALL_H__ */ --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list