From nobody Tue Apr 30 10:04:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1504623169843488.9697386457726; Tue, 5 Sep 2017 07:52:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 679FEC00E0D9; Tue, 5 Sep 2017 14:52:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 435177FB90; Tue, 5 Sep 2017 14:52:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5D48D62D0F; Tue, 5 Sep 2017 14:52:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v85EbSJg014067 for ; Tue, 5 Sep 2017 10:37:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 39CE287B22; Tue, 5 Sep 2017 14:37:28 +0000 (UTC) Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3381B87B29 for ; Tue, 5 Sep 2017 14:37:26 +0000 (UTC) Received: from m15-112.126.com (m15-112.126.com [220.181.15.112]) by mx1.redhat.com (Postfix) with ESMTP id AE26F935BE for ; Tue, 5 Sep 2017 14:37:23 +0000 (UTC) Received: from localhost.localdomain.localdomain (unknown [58.213.111.46]) by smtp2 (Coremail) with SMTP id DMmowABHFu9Yr65ZeDeHAg--.52351S2; Tue, 05 Sep 2017 22:06:25 +0800 (CST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 679FEC00E0D9 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=126.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 679FEC00E0D9 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (1024-bit key) header.d=126.com header.i=@126.com header.b="oDpZaY5m" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AE26F935BE Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=chen_han_xiao@126.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AE26F935BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=01d3qBA6WbwJYkF9MI x30DBqPUkroEshfil17aUwtPk=; b=oDpZaY5mPH2p/PzL/C8SPi0y20aPMp79Jh d7ykcZ2lsYFKHwcknisRw6YANRxRb6fk7d/lgveZ99ZFvbJgZAtd0CH3BPhFc/G/ k6SCTijLOjdQbFLFDgWX+6iUp0ioXnXNmwVZursV86TWexG+i9gPweM+WUKZY6aM +Y+Nm76yk= From: Chen Hanxiao To: libvir-list@redhat.com Date: Tue, 5 Sep 2017 22:01:56 +0800 Message-Id: <1504620116-19623-1-git-send-email-chen_han_xiao@126.com> X-CM-TRANSID: DMmowABHFu9Yr65ZeDeHAg--.52351S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7CFykKw1DCFW8tF17Cr1UAwb_yoW8Gw4fp3 Z8ta1rZr4qqr1fKw1DGayFqF1YyayUWryrWa9avr4UZr45Grs7Xr13XrZ0vw4DXrWFkF4f CFnrKa47uFnYyr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07USPfdUUUUU= X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbikgNKrlag33oykQAAsF X-Greylist: Delayed for 00:30:56 by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 05 Sep 2017 14:37:25 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 05 Sep 2017 14:37:25 +0000 (UTC) for IP:'220.181.15.112' DOMAIN:'m15-112.126.com' HELO:'m15-112.126.com' FROM:'chen_han_xiao@126.com' RCPT:'' X-RedHat-Spam-Score: 1.999 * (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_PSBL, RP_MATCHES_RCVD, SPF_PASS) 220.181.15.112 m15-112.126.com 220.181.15.112 m15-112.126.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Chen Hanxiao Subject: [libvirt] [PATCH] domain: add limit description of parameter 'size' for blockPeek and memoryPeek X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 05 Sep 2017 14:52:48 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Chen Hanxiao We had 'size' limits for virDomainMemoryPeek and virDomainBlockPeek by macro REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX and REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX. The descriptions of the two functions only emphasized RPC buffer size. Signed-off-by: Chen Hanxiao --- src/libvirt-domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index ca5a153..646ce72 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -5802,6 +5802,9 @@ virDomainMemoryStats(virDomainPtr dom, virDomainMemor= yStatPtr stats, * within the device or file. 'size' may be 0 to test if the * call would succeed. * + * 'size' should be <=3D 1048576(1M). Since v1.0.5, 'size' had been + * raised up to 4194304(4M). + * * 'buffer' is the return buffer and must be at least 'size' bytes. * * NB. The remote driver imposes a 64K byte limit on 'size'. @@ -5941,6 +5944,9 @@ virDomainBlockResize(virDomainPtr dom, * 'buffer' is the return buffer and must be at least 'size' bytes. * 'size' may be 0 to test if the call would succeed. * + * 'size' should be <=3D 1048576(1M). Since v1.0.5, 'size' had been + * raised up to 4194304(4M). + * * NB. The remote driver imposes a 64K byte limit on 'size'. * For your program to be able to work reliably over a remote * connection you should split large requests to <=3D 65536 bytes. --=20 2.7.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list