From nobody Mon Sep 16 19:20:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 172173750230399.38865768384562; Tue, 23 Jul 2024 05:25:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3292DA20; Tue, 23 Jul 2024 08:25:01 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id BFE90A5A; Tue, 23 Jul 2024 08:24:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A4D84A26; Tue, 23 Jul 2024 08:24:42 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D4FBAA35 for ; Tue, 23 Jul 2024 08:24:39 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-QtpfdMBHOZi-HFKdWhjHrQ-1; Tue, 23 Jul 2024 08:24:38 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7347319560B3 for ; Tue, 23 Jul 2024 12:24:37 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.225.28]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 75E951955D4A for ; Tue, 23 Jul 2024 12:24:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721737479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m8fPKpN8riLoWzvMtLsUyWsNLDaedBXfn7JlSnP4Qng=; b=OJ2+RJBBs5SbBnEOH56WEetwwgv7DrwShK9g2chvisd5jPrOMwOdBAjYnCgoX2oYSQ4fEa BenzTWzEyAOnqlJz8cvsxTdTNUISmiunvKqjTGpVr2RpppMGcn8wd09olUtAdtxpAQrjk1 7HFcr1OsxcxFmfmHR8AzWM88XLf5IYs= X-MC-Unique: QtpfdMBHOZi-HFKdWhjHrQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH] qemu: virtiofs: cache: use 'never' instead of 'none' Date: Tue, 23 Jul 2024 14:24:28 +0200 Message-ID: <15010c162f812c777f24271def7645550ad7bec1.1721737468.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NCHJZU5CYDNSHLWW6KIIQ6TXW42C4G3T X-Message-ID-Hash: NCHJZU5CYDNSHLWW6KIIQ6TXW42C4G3T X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1721737503574116600 Content-Type: text/plain; charset="utf-8" The new option style renamed one of the cache modes. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/qemu/qemu_virtiofs.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 703f1226a2..db987ddfe1 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src/qemu/qemu_virtiofs.c @@ -147,10 +147,19 @@ qemuVirtioFSBuildCommandLine(virQEMUDriverConfig *cfg, virCommandAddArg(cmd, "--shared-dir"); virCommandAddArg(cmd, fs->src->path); =20 - if (fs->cache) { + switch (fs->cache) { + case VIR_DOMAIN_FS_CACHE_MODE_DEFAULT: + break; + case VIR_DOMAIN_FS_CACHE_MODE_NONE: + virCommandAddArg(cmd, "--cache"); + virCommandAddArg(cmd, "never"); + break; + case VIR_DOMAIN_FS_CACHE_MODE_ALWAYS: virCommandAddArg(cmd, "--cache"); virCommandAddArg(cmd, virDomainFSCacheModeTypeToString(fs->cac= he)); + break; } + if (fs->sandbox) { virCommandAddArg(cmd, "--sandbox"); virCommandAddArg(cmd, virDomainFSSandboxModeTypeToString(fs->s= andbox)); --=20 2.45.2