From nobody Fri Oct 18 08:50:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1718117363519338.86524979538797; Tue, 11 Jun 2024 07:49:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 71243C94; Tue, 11 Jun 2024 10:49:22 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E8894C2F; Tue, 11 Jun 2024 10:48:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id ABC749DD; Tue, 11 Jun 2024 10:48:22 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4AB079DD for ; Tue, 11 Jun 2024 10:48:22 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-gokT3_RGNkuDEqsglko5Mg-1; Tue, 11 Jun 2024 10:48:19 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C5619195608D for ; Tue, 11 Jun 2024 14:48:18 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.20]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E62963000627 for ; Tue, 11 Jun 2024 14:48:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718117302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pr/uyLP/1+bhXG+I/UoOuA7E70ivDJuuXyQWc3n7D4M=; b=I/dndArrtcHaIvzmWlcJgwMYzD3zJ5h17+wqJ3jyZBb42eiHpCNn7An5hyIpgoh51MovwZ 3uKglgQcer5nbC97VpUbsIgdxnYlHtEYo8IFiQrxINUTY3lPbLGLbhkhHSs4amiGIvScpH Uj8PM9yr7kYVLarpx3CSDuB95dpsPog= X-MC-Unique: gokT3_RGNkuDEqsglko5Mg-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 2/3] qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices Date: Tue, 11 Jun 2024 16:48:12 +0200 Message-ID: <14f936f288a2090cc7b265959fe675c551bcc275.1718117248.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GWE4EYA5BD4YCFUQQLDF2FGLKW5PKCLZ X-Message-ID-Hash: GWE4EYA5BD4YCFUQQLDF2FGLKW5PKCLZ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1718117365632100001 Content-Type: text/plain; charset="utf-8" The support will be dropped soon by qemu, and libvirt is not rejecting such configurations. Add validation of this explicitly requested config. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index fe190cea36..e69874801e 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2912,6 +2912,11 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDom= ainDiskDef *disk, break; case VIR_DOMAIN_DISK_BUS_VIRTIO: + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_SCSI)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("This QEMU doesn't support SCSI emulation= with 'virtio-blk' device")); + return -1; + } break; case VIR_DOMAIN_DISK_BUS_NONE: --=20 2.45.2