.gitignore | 2 +- .submodules/gnulib.functions | 65 ++++++++++ autogen.sh | 286 +++++++++++++++++++++++++++++-------------- cfg.mk | 34 ++--- 4 files changed, 265 insertions(+), 122 deletions(-) create mode 100644 .submodules/gnulib.functions
This work was motivated by Dan's intention to introduce the keycodemapdb module into libvirt[1]. As it is, we have a few useful submodule-related features in our build system, but they are limited in that they assume there will be a single submodule, and it will be gnulib. This series removes such assumptions, making it possible to introduce more submodules without having to sacrifice any convenience. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html Andrea Bolognani (2): autogen.sh: Rewrite autogen.sh: Modularize .gitignore | 2 +- .submodules/gnulib.functions | 65 ++++++++++ autogen.sh | 286 +++++++++++++++++++++++++++++-------------- cfg.mk | 34 ++--- 4 files changed, 265 insertions(+), 122 deletions(-) create mode 100644 .submodules/gnulib.functions -- 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Apr 18, 2017 at 04:31:16PM +0200, Andrea Bolognani wrote: > This work was motivated by Dan's intention to introduce the > keycodemapdb module into libvirt[1]. As it is, we have a few > useful submodule-related features in our build system, but > they are limited in that they assume there will be a single > submodule, and it will be gnulib. What is it that makes out submodule handling so complicated. eg in gtk-vnc and spice-gtk, we have a trivial line in autogen.sh 'git submodule update --init --recursive' that takes care of it. Is all the complexity we see caused by the need to detect when to re-run bootstrap for gnulib ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, 2017-04-18 at 16:41 +0100, Daniel P. Berrange wrote: > What is it that makes out submodule handling so complicated. eg in gtk-vnc > and spice-gtk, we have a trivial line in autogen.sh > > 'git submodule update --init --recursive' > > that takes care of it. Is all the complexity we see caused by the need to > detect when to re-run bootstrap for gnulib ? Pretty much, yeah. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Apr 19, 2017 at 09:02:50AM +0200, Andrea Bolognani wrote: > On Tue, 2017-04-18 at 16:41 +0100, Daniel P. Berrange wrote: > > What is it that makes out submodule handling so complicated. eg in gtk-vnc > > and spice-gtk, we have a trivial line in autogen.sh > > > > 'git submodule update --init --recursive' > > > > that takes care of it. Is all the complexity we see caused by the need to > > detect when to re-run bootstrap for gnulib ? > > Pretty much, yeah. This still feels over-engineered to me. I don't really see the benefit in creating modular files like .submodules/keycodemapdb.functions - it is a generic facility that is unlikely to ever be needed by anything other than gnulib. It feels like we ought to be able to just have the general purpose submodule update as above, and then just decide if we need to rerun bootstrap after that Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, 2017-04-19 at 10:06 +0100, Daniel P. Berrange wrote: > This still feels over-engineered to me. I don't really see the benefit in > creating modular files like .submodules/keycodemapdb.functions - it is a > generic facility that is unlikely to ever be needed by anything other than > gnulib. > > It feels like we ought to be able to just have the general purpose > submodule update as above, and then just decide if we need to rerun > bootstrap after that I'll try to come up with something :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.