From nobody Sat Feb 7 09:36:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1490169761200960.2687755367946; Wed, 22 Mar 2017 01:02:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B4CB61B8E; Wed, 22 Mar 2017 08:02:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45FE618342; Wed, 22 Mar 2017 08:02:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E3C6418523C6; Wed, 22 Mar 2017 08:02:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2M82VSR006922 for ; Wed, 22 Mar 2017 04:02:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id AB4D2B9298; Wed, 22 Mar 2017 08:02:31 +0000 (UTC) Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A21CBB9295 for ; Wed, 22 Mar 2017 08:02:30 +0000 (UTC) Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52A6413D15 for ; Wed, 22 Mar 2017 08:02:29 +0000 (UTC) Received: by mail-pf0-f193.google.com with SMTP id r137so21743544pfr.3 for ; Wed, 22 Mar 2017 01:02:28 -0700 (PDT) Received: from prerna-saxena.dev.eng.nutanix.com. (206-15-90-246.static.twtelecom.net. [206.15.90.246]) by smtp.gmail.com with ESMTPSA id a62sm1939099pgc.60.2017.03.22.01.02.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 01:02:26 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7B4CB61B8E Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7B4CB61B8E Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ez3X+wzw" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 52A6413D15 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=saxenap.ltc@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 52A6413D15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=81aMLpErXocmiZMnIFhsdFf6JkqFSR2DNyo/5FcRjq4=; b=ez3X+wzw0Ww6DFpDGl9hm+PezwlQEnhWuzFCQb/6HT212/noICqn5wDzR4eUhOA6Yi v8U5wLoJBrx3oru4F9av9ga2rcjwXWajQlZk/eJm8APEWAYz837/5PJfB1esjmm+pyYF +fwDBNq+2Ysk70s2njVB6VsLHmzebPD9P2Zo6/FUXeXsVdXuo/T/f6R9JwHnOaEXzzQV LOd+tZoS946nRL6dyz0fn9qHv3IPGnC0M0tKGZ+1Fsm+fgrFSbyh5otZxRVzlhTy4r8U 604M1MAfZwJuXLQyDoCezK7TbXZOGfCnciB1u5ZO1rpE9L72Up5TEtRYaW73ikDK5u// 1J1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=81aMLpErXocmiZMnIFhsdFf6JkqFSR2DNyo/5FcRjq4=; b=HIoVxzk+FCtiJCAePlJktgHJIkrWy6rY/jF51EpqEgeY6301H/NRmJAqGRtQt06Kmd jxKbH7jeIr6sfYmUKs8owN0TbI6NE/jFYmGHwOLBUBTGy0ANy3lMT9HTVTy4wB/ZyGIz vC2bJvRtq3hZFr1afRruIuuyNoj6ZPCkog9cNziViPEu22c6lDCWQL0bHlDfgf3ig6Vx x332M3ZNqxtYvOw8cQw1yjzMmGkaLdkI2jJzUTOSfl0n8EWPWkOhEqRn/Zd0sdvg7qK6 dmz58AFN/rwUL6slsDRpaFfPK0YBUsO3/j2gWuAUPIzQ5cCPQFLAXBFPOnskXBgV524e fIpQ== X-Gm-Message-State: AFeK/H3gJBefj3ov9XsM+WvX0UHFmcFcvU/X+d6rQAtF3nGTXo7exg6bjxXciEDC1GS+0Q== X-Received: by 10.99.101.67 with SMTP id z64mr43323869pgb.78.1490169747464; Wed, 22 Mar 2017 01:02:27 -0700 (PDT) From: Prerna Saxena To: libvirt-list@redhat.com Date: Wed, 22 Mar 2017 01:02:18 -0700 Message-Id: <1490169739-17852-3-git-send-email-saxenap.ltc@gmail.com> In-Reply-To: <1490169739-17852-1-git-send-email-saxenap.ltc@gmail.com> References: <1490169739-17852-1-git-send-email-saxenap.ltc@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 22 Mar 2017 08:02:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 22 Mar 2017 08:02:29 +0000 (UTC) for IP:'209.85.192.193' DOMAIN:'mail-pf0-f193.google.com' HELO:'mail-pf0-f193.google.com' FROM:'saxenap.ltc@gmail.com' RCPT:'' X-RedHat-Spam-Score: -1.61 (BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.192.193 mail-pf0-f193.google.com 209.85.192.193 mail-pf0-f193.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 22 Mar 2017 08:02:41 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Sample from current logs: error : virFileReadAll:1290 : Failed to open file '/sys/class/net/tap3/oper= state': No such file or directory error : virNetDevGetLinkInfo:1895 : unable to read: /sys/class/net/tap3/ope= rstate: No such file or directory These have no useful data point and are redundant. Signed-off-by: Prerna Saxena --- src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index d123248..3e2f962 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1874,7 +1874,7 @@ virNetDevGetLinkInfo(const char *ifname, if (virNetDevSysfsFile(&path, ifname, "operstate") < 0) goto cleanup; =20 - if (virFileReadAll(path, 1024, &buf) < 0) { + if (virFileReadAllQuiet(path, 1024, &buf) < 0 && errno !=3D ENOENT) { virReportSystemError(errno, _("unable to read: %s"), path); --=20 1.8.1.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list