From nobody Sat Feb 7 08:45:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.37 as permitted sender) client-ip=209.132.183.37; envelope-from=libvir-list-bounces@redhat.com; helo=mx5-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.37 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) by mx.zohomail.com with SMTPS id 1488474424145855.3897385741938; Thu, 2 Mar 2017 09:07:04 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v22H3rVF011619; Thu, 2 Mar 2017 12:03:53 -0500 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v22H31ca028410 for ; Thu, 2 Mar 2017 12:03:01 -0500 Received: by smtp.corp.redhat.com (Postfix) id A631D15A81; Thu, 2 Mar 2017 17:03:01 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.34.129.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D16D15A80 for ; Thu, 2 Mar 2017 17:03:00 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 2 Mar 2017 18:02:55 +0100 Message-Id: <1488474176-14427-2-git-send-email-abologna@redhat.com> In-Reply-To: <1488474176-14427-1-git-send-email-abologna@redhat.com> References: <1488474176-14427-1-git-send-email-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] qemu: Don't omit parentheses X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The ARCH_IS_*() macro are defined in a way that allows them to be used if a parentheses-less if statement, but we don't really want that to happen --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 6f60a00..ceda769 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -785,7 +785,7 @@ virQEMUCapsProbeCPUModels(virQEMUCapsPtr qemuCaps, uid_= t runUid, gid_t runGid) if (qemuCaps->arch =3D=3D VIR_ARCH_I686 || qemuCaps->arch =3D=3D VIR_ARCH_X86_64) { parse =3D virQEMUCapsParseX86Models; - } else if ARCH_IS_PPC64(qemuCaps->arch) { + } else if (ARCH_IS_PPC64(qemuCaps->arch)) { parse =3D virQEMUCapsParsePPCModels; } else { VIR_DEBUG("don't know how to parse %s CPU models", --=20 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list