[libvirt] [PATCH 3/4] spec: Require libacl and its headers

Andrea Bolognani posted 4 patches 157 weeks ago

[libvirt] [PATCH 3/4] spec: Require libacl and its headers

Posted by Andrea Bolognani 157 weeks ago
Now that they're required by configure, we should make sure
they are available when building the rpm and when installing it.
---
 libvirt.spec.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index e8c272b..ca569e3 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -340,6 +340,8 @@ BuildRequires: polkit-devel >= 0.93
 # For mount/umount in FS driver
 BuildRequires: util-linux
 %if %{with_qemu}
+# For managing ACLs
+BuildRequires: libacl-devel
 # From QEMU RPMs
 BuildRequires: /usr/bin/qemu-img
 %else
@@ -645,6 +647,8 @@ Requires: xz
     %if 0%{?fedora} >= 24
 Requires: systemd-container
     %endif
+# For managing ACLs
+Requires: libacl
 
 %description daemon-driver-qemu
 The qemu driver plugin for the libvirtd daemon, providing
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/4] spec: Require libacl and its headers

Posted by Michal Privoznik 157 weeks ago
On 02/14/2017 04:33 PM, Andrea Bolognani wrote:
> Now that they're required by configure, we should make sure
> they are available when building the rpm and when installing it.
> ---
>  libvirt.spec.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e8c272b..ca569e3 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -340,6 +340,8 @@ BuildRequires: polkit-devel >= 0.93
>  # For mount/umount in FS driver
>  BuildRequires: util-linux
>  %if %{with_qemu}
> +# For managing ACLs
> +BuildRequires: libacl-devel
>  # From QEMU RPMs
>  BuildRequires: /usr/bin/qemu-img
>  %else
> @@ -645,6 +647,8 @@ Requires: xz
>      %if 0%{?fedora} >= 24
>  Requires: systemd-container
>      %endif
> +# For managing ACLs
> +Requires: libacl

This shouldn't be needed. If we are building with libacl-devel, we are
also linking with libacl and thus rpm will put it as a requirement.

ACK if you drop this hunk.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/4] spec: Require libacl and its headers

Posted by Andrea Bolognani 157 weeks ago
On Tue, 2017-02-14 at 17:39 +0100, Michal Privoznik wrote:
> > @@ -645,6 +647,8 @@ Requires: xz
> >      %if 0%{?fedora} >= 24
> >  Requires: systemd-container
> >      %endif
> > +# For managing ACLs
> > +Requires: libacl
> 
> This shouldn't be needed. If we are building with libacl-devel, we are
> also linking with libacl and thus rpm will put it as a requirement.

So it does! Looks like I learned a new trick today :)

> ACK if you drop this hunk.

I've pushed this after dropping the hunk and tweaking the
commit message a bit. Same with the other patches in the
series, except of course for 2/4.

Thanks!

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list