From nobody Mon Feb 2 07:30:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1768823335; cv=none; d=zohomail.com; s=zohoarc; b=BfKwdfmtwbQ7KbqRh0YFIu/IjyFnJvxg6ldQV7GNPi0BV8C4+ex0Dl4M04//uivdYafAeZ/gkxlCVkgI2iPDknIif36GgzRs1dvcA3cXZBRBkCx6qlnI+yNkoRrNAfSFA6PrdWbrSG9fPy7vLt78UxiEfgTMNkIvStoOCAQsncE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768823335; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=b1TK5LcrYNFIvJH9EEI466rPQ4Igr+IRa0Y4Ybbm22c=; b=O5yJ7Fj2zLf8sikd1k88SkwTCo57KutgS2E/i++k2vBE9lg1HNPtpwEGU8rAq/P+xVyXKGmvoAM2luWwGp8GkwPcbqXAZMoTm5AESETBtJR4VCLgHzFS8FjYIisrntIpv26A6Ln0Rb9Ta6sKnGS+tHq1YpSHAlFIASpu0oaxwro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1768823335503770.8774875213663; Mon, 19 Jan 2026 03:48:55 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 8F75D43DF7; Mon, 19 Jan 2026 06:48:54 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 63EFF43F80; Mon, 19 Jan 2026 06:46:59 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 8CC9741BA1; Mon, 19 Jan 2026 06:46:50 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1575C41C3D for ; Mon, 19 Jan 2026 06:46:50 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-7t1zhLMNNN280p0_c4vOPw-1; Mon, 19 Jan 2026 06:46:48 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B21C21800473 for ; Mon, 19 Jan 2026 11:46:47 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4B9F819560A7 for ; Mon, 19 Jan 2026 11:46:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768823209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1TK5LcrYNFIvJH9EEI466rPQ4Igr+IRa0Y4Ybbm22c=; b=hfAYl8HMYkmu/JYdkqTIkkdS/X/fggFEgAKyhHq6ebn376ZG0GMEt8cHRQjf4TtuIq8kLR eeJ5NYpu9Lb8tui8f0EoOAU0Qztb5soGDc52whHzMqqIP5SVKEL5NLYDbYER3ags7bqXDE 1iqud4IXgA/Gt97xLRfG0EBSt1KWUSY= X-MC-Unique: 7t1zhLMNNN280p0_c4vOPw-1 X-Mimecast-MFC-AGG-ID: 7t1zhLMNNN280p0_c4vOPw_1768823207 To: devel@lists.libvirt.org Subject: [PATCH v2 2/3] libvirt-guest.sh.in: Fix logical error in guest_is_on() Date: Mon, 19 Jan 2026 12:46:42 +0100 Message-ID: <12f285573136ee69644fe10fa4bebe8d709a2997.1768823107.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: b9w1G1tp5lkoSldr1q6jhg0m81-r43C0SjmZrWHYj70_1768823207 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GWIYMBP4XJX7JYHCXJ3XADTA7DT2R7BS X-Message-ID-Hash: GWIYMBP4XJX7JYHCXJ3XADTA7DT2R7BS X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1768823336130158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The guest_is_on() function is documented to check whether given domain is running and set guest_running variable accordingly. It does so by running virsh (transitively), then setting the variable and only after that comparing $? variable. This is obviously wrong, because after the guest_running variable assignment the $? variable no longer holds the exit code of virsh. Even worse, as explained in the previous commit, it never held that value in the first place. Fix this by firstly setting the global variable and only after that running virsh. Fixes: 08071ec0f113bb1fe8dcc263cb6bf87529e8b76b Resolves: https://gitlab.com/libvirt/libvirt/-/issues/839 Signed-off-by: Michal Privoznik --- tools/libvirt-guests.sh.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index e05bfdba61..66a39b9178 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -132,9 +132,10 @@ guest_name() { guest_is_on() { local uri=3D"$1" local uuid=3D"$2" - local id=3D"$(run_virsh "$uri" domid "$uuid")" + local id =20 guest_running=3D"false" + id=3D"$(run_virsh "$uri" domid "$uuid")" if [ $? -ne 0 ]; then RETVAL=3D1 return 1 --=20 2.52.0