From nobody Mon Feb 9 01:06:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585567380; cv=none; d=zohomail.com; s=zohoarc; b=T9EGXKWEgkHFfo1vQKPl2Dgf0bYAPo6Qj+Uq27Il4wC2TST+NXAODy8D5DDRl7tkhEAH3tlTV7+xQ3B+oA+2X1LfSN/tG59H+2WUmgVbASXL+qbl8NzPgoOtu1FydS9MidBb/UKk9kgbqm6udw7RdwrcVK8NcUSugxAsYspaTIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585567380; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jYxlanxG0Xw7sUd/ahFpUg/HvWBhP+VCgVrWXhLwgFE=; b=QoM1tkp7wgRmkq20POQGttuLSHyt4GKT3fOvtigJhb2fmLfr6XTCGTnO6e47AxiLKl6rbM1DmJARV0A05Vh7Rl0myOcNOZGNwn2MgyjRE/dbMIUqMpkRgeP2zjzrH1OXPRhcsrLbLarQOiwp/xT5h6L3YMXrZiB1/9wLh9f8YX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1585567380810372.6511876051411; Mon, 30 Mar 2020 04:23:00 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-TxIoRQnmMdWJoq5ZBtRtPg-1; Mon, 30 Mar 2020 07:22:57 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6CD3100551A; Mon, 30 Mar 2020 11:22:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A5B6100EBAD; Mon, 30 Mar 2020 11:22:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3ACDF944CC; Mon, 30 Mar 2020 11:22:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02UBLYr7011058 for ; Mon, 30 Mar 2020 07:21:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4EF66100EBB1; Mon, 30 Mar 2020 11:21:34 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7CB3100EBAD for ; Mon, 30 Mar 2020 11:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585567379; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jYxlanxG0Xw7sUd/ahFpUg/HvWBhP+VCgVrWXhLwgFE=; b=DdBJZPfoTE4HuHfgEwpxY/nS0ZbCnEvQJqiXIocFZjBKPQUMnsNmZTBOVmJNLOMQ0flNbk 1cae/WxYZaGGXKfdwGuLG4gKcFWRWvdBPSJUpCyCHW5cmhuHi6BaaDdmqi3QHdjVZpDfWw kqMTnds9frm0svUZrsQ4ISDuJkqcBr4= X-MC-Unique: TxIoRQnmMdWJoq5ZBtRtPg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/2] qemuDomainSnapshotDiskPrepareOne: Don't load the relative path with blockdev Date: Mon, 30 Mar 2020 13:21:28 +0200 Message-Id: <1152a027238c01b9dcd035c062a465d9b5c2828a.1585567181.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since we are refreshing the relative paths when doing the blockjobs we no longer need to load them upfront when doing the snapshot. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae38b9c914..78024614cf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15167,8 +15167,9 @@ qemuDomainSnapshotDiskPrepareOne(virQEMUDriverPtr d= river, dd->initialized =3D true; /* relative backing store paths need to be updated so that relative - * block commit still works */ - if (reuse) { + * block commit still works. With blockdev we must update it when = doing + * commit anyways so it's skipped here */ + if (reuse && !blockdev) { if (supportsBacking) { g_autofree char *backingStoreStr =3D NULL; --=20 2.24.1