From nobody Mon May 6 08:56:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563464335; cv=none; d=zoho.com; s=zohoarc; b=WPYzvhWylEBpjfagPjEA21Q07T/3+IjSQlOimMjiD4sGlCjR1e+b2J04kaO4H5uchCh9wy2pSA3MBQIYydQFcdq8uXjsfxOedWY5Z28LX6N9MKeSl96aN8k6SmJ5pe7WWYl2qaUUAJyEriT5gsFGHBO9FB9j1paz5b+tPs0p84c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563464335; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=KH1RtTb39qkHLve9Nlg+UsGxq7UeZyQCMRS4NTIMaPU=; b=Xe8Dk3qrc4xscfda0D/PaMkwDyDlwLaXb/hs7pTDKQM36RNFF3lmLIZUXPH7zH+f5G9eCIX8UEbe3yeO1oLsPiT+pDjg4pnfn0tZUddejUPegmzA34/ukEjiTX0E6jJTzqhWtY1PEsM8JklC8FSG/NekHisVcPu4gwCntktsgBU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563464335276560.5711338136863; Thu, 18 Jul 2019 08:38:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E7EB30C34F0; Thu, 18 Jul 2019 15:38:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E29041001B02; Thu, 18 Jul 2019 15:38:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2B33A1800206; Thu, 18 Jul 2019 15:38:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6IFcpxd025840 for ; Thu, 18 Jul 2019 11:38:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7CDDC179EE; Thu, 18 Jul 2019 15:38:51 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id F21E717BA9 for ; Thu, 18 Jul 2019 15:38:41 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 18 Jul 2019 17:38:40 +0200 Message-Id: <112174b2054438e9851e020db47610ca1bfad2a0.1563464306.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] network: Link with libxml2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 18 Jul 2019 15:38:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Since fb9f6ce6253 we are including a libxml header file in the network driver but never link with it. This hasn't caused an immediate problem because in the end the network driver links with libvirt.la. But apparently, it's causing a build issue on old Ubuntu. Signed-off-by: Michal Privoznik --- Pushed under trivial & build breaker rules. src/network/Makefile.inc.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index 52270049d5..23cf39b6f4 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -47,7 +47,7 @@ libvirt_driver_network_impl_la_CFLAGS =3D \ $(AM_CFLAGS) \ $(NULL) libvirt_driver_network_impl_la_SOURCES =3D $(NETWORK_DRIVER_SOURCES) -libvirt_driver_network_impl_la_LIBADD =3D $(DBUS_LIBS) +libvirt_driver_network_impl_la_LIBADD =3D $(DBUS_LIBS) $(LIBXML_LIBS) =20 libexec_PROGRAMS +=3D libvirt_leaseshelper libvirt_leaseshelper_SOURCES =3D $(NETWORK_LEASES_HELPER_SOURCES) --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list