From nobody Sun Feb 8 03:27:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1670937772; cv=none; d=zohomail.com; s=zohoarc; b=HN5lSITZUMLUdFkeQue75cdZ33kGodcdLci8OffwU8mCTK2IXrSF2YrqXz5QwJH83x7U45ulUUwDaN4ek5asg/e9heZ/BPQsDRYX3/Mmr9O3w9dqeu3kJZ1kH1f4Xw7NXO8SpFJE1Esw1wEW8B24kDpKWMU/3XnDQNmnJ7JXlrE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670937772; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=z6U7sGCP/tVEuXKKdO/hgRcT2MWN+Ek8cJwee5/csTg=; b=DOqA0Ado3gX6oed5LBIn4Ffq6MhiikMCgH1Dm+We0uwodRVtHrJUa32dP2dJbaqjRO2cSZK640BFZl2KZQL/KXc2ZOQ7+BiFYH9Xr2P3batFgqs/K8ZoL5TLm39wLxkpaMPDvCL0a9qR1dScBGuqrYG+hqnx2shqRp6mxGaECAY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1670937772716533.9390878922544; Tue, 13 Dec 2022 05:22:52 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-210-5kV_X3O_Ph2btcDkFYsfrw-1; Tue, 13 Dec 2022 08:22:47 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B13F43815D2A; Tue, 13 Dec 2022 13:22:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 353DB14152F4; Tue, 13 Dec 2022 13:22:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DF2CB1946588; Tue, 13 Dec 2022 13:22:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C3D001946586 for ; Tue, 13 Dec 2022 13:22:42 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9CA4E1121315; Tue, 13 Dec 2022 13:22:42 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CE241121314 for ; Tue, 13 Dec 2022 13:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670937771; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=z6U7sGCP/tVEuXKKdO/hgRcT2MWN+Ek8cJwee5/csTg=; b=PZSNvR8Z7WoB/g6krZeRxiM8Fkqis4GY+E0Xfr+AIpFgMqO36pvZGrNkmfBh9QL2SVseO8 ePizjvqQAOomGpmxylMNFk7pefys1g3m/mit7MSBetqgZUvthBVbYec5Q9wcxZF/qSPajU SCtguYfG3sqr5ZCcfZ6TIYumtUzjuzc= X-MC-Unique: 5kV_X3O_Ph2btcDkFYsfrw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: Fix warning in qemuMigrationDstPostcopyFailed Date: Tue, 13 Dec 2022 14:22:40 +0100 Message-Id: <110f9cf76bd97870b25ef5601af1cbdc87fae6b2.1670937760.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1670937773747100001 Content-Type: text/plain; charset="utf-8" The function is called even if QEMU reports migration as postcopy-paused, i.e., it's not migrating anymore. And while changing the warning, we can drop the part about unattended migration to make the warning shorter and consistent with qemuMigrationSrcPostcopyFailed. Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa --- src/qemu/qemu_migration.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 81bb08c029..2e87db883e 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1704,9 +1704,8 @@ qemuMigrationDstPostcopyFailed(virDomainObj *vm) reason =3D=3D VIR_DOMAIN_RUNNING_POSTCOPY_FAILED) return; =20 - VIR_WARN("Migration protocol failed during incoming migration of domai= n " - "%s, but QEMU keeps migrating; leaving the domain running, th= e " - "migration will be handled as unattended", vm->def->name); + VIR_WARN("Incoming migration of domain %s failed during post-copy; " + "leaving the domain running", vm->def->name); =20 virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_POSTCOPY_FAILED); --=20 2.39.0