From nobody Sun Feb 8 19:56:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631177383; cv=none; d=zohomail.com; s=zohoarc; b=n4NfIupIQX5xTmD8x1C6V4Pz9qMFlMAdckumEw/XXwPZ9HgxOTh/UOcFTY63raZtiPIbrv//tcrOu4s+GZ8zk8aTNPQVY/UaRUYpDqYc7t4kjZSeHu90+q5q9yrWaTyd6CqxHp3gU7jk4/lhvzxHAipBU4Uv+oOSRIV+6lPVFtU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631177383; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Oq7JFaOUCpxeacRSHHsAknGbDk8Pozys65RYEw27op0=; b=m+4n1rSodvV5mFiUX8EKpMOswCuVH7rhKepZ7hCPaYVM8SZjGh2VlnghzNNFi1ocNil9BVhNpUMZSpdFXzvzXr02ao5/N9eWeZ+e0Kq2+hfhsheQCHuxgywh/nvISx9NkCB3BZWec/tr04ifnpQwL+9DbG1LWblrVRKV5e3+gZ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1631177383405968.3545161413142; Thu, 9 Sep 2021 01:49:43 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-GiYOzts8OOGHwIV8BYns9g-1; Thu, 09 Sep 2021 04:49:40 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4AB91835AC8; Thu, 9 Sep 2021 08:49:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6CE05453A; Thu, 9 Sep 2021 08:49:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 74A954EA30; Thu, 9 Sep 2021 08:49:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1898nVrR030049 for ; Thu, 9 Sep 2021 04:49:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 080CB19D9B; Thu, 9 Sep 2021 08:49:31 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A58619736 for ; Thu, 9 Sep 2021 08:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631177382; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Oq7JFaOUCpxeacRSHHsAknGbDk8Pozys65RYEw27op0=; b=OlqrBh5Mi5urkZyRkXzfrh4leLXWAIsMX5P23+rI8T9pJ5jeJkQcAEfekSGI6r7230ugE9 +c+6+76432XQGP1iJCZugQEVw6g/L64N9RD3HzAlu1Gt7U/BMKgp02wb3stskjkp77NELa YkXQMoocfKboeRwq7F9sXedoBlTX4mc= X-MC-Unique: GiYOzts8OOGHwIV8BYns9g-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/24] virstoragetest: Drop testing of RBD backends via parsing real images Date: Thu, 9 Sep 2021 10:49:01 +0200 Message-Id: <10d19c2e2f2bad899bd788aecb969232c60f9c51.1631177237.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631177384733100006 Content-Type: text/plain; charset="utf-8" We now have specific tests for the backing store parser and previous tests cover the extraction of the backing store string so there's no need for these particular tests. Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 38 -------------------------------------- 1 file changed, 38 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index b80818bc7b..ab34f2f3be 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -799,44 +799,6 @@ mymain(void) /* Behavior of an infinite loop chain */ TEST_CHAIN(abswrap, VIR_STORAGE_FILE_QCOW2, (&wrap, &qcow2), EXP_FAIL); - /* Rewrite qcow2 to use an rbd: protocol as backend */ - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-F", "raw", "-b", "rbd:testshare", - "qcow2", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - qcow2.expBackingStoreRaw =3D "rbd:testshare"; - - /* Qcow2 file with backing protocol instead of file */ - testFileData rbd1 =3D { - .path =3D "testshare", - .type =3D VIR_STORAGE_TYPE_NETWORK, - .format =3D VIR_STORAGE_FILE_RAW, - .protocol =3D VIR_STORAGE_NET_PROTOCOL_RBD, - }; - TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2, &rbd1), EXP_PASS= ); - - /* Rewrite qcow2 to use an rbd: protocol as backend */ - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-F", "raw", "-b", "rbd:testshare:id=3Dasdf= :mon_host=3Dexample.com", - "qcow2", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - qcow2.expBackingStoreRaw =3D "rbd:testshare:id=3Dasdf:mon_host=3Dexamp= le.com"; - - /* Qcow2 file with backing protocol instead of file */ - testFileData rbd2 =3D { - .path =3D "testshare", - .type =3D VIR_STORAGE_TYPE_NETWORK, - .format =3D VIR_STORAGE_FILE_RAW, - .protocol =3D VIR_STORAGE_NET_PROTOCOL_RBD, - .secret =3D "asdf", - .hostname =3D "example.com", - }; - TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2, &rbd2), EXP_PASS= ); - VIR_WARNINGS_RESET /* Rewrite wrap and qcow2 back to 3-deep chain, absolute backing */ --=20 2.31.1