From nobody Sat May 4 03:34:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636103903; cv=none; d=zohomail.com; s=zohoarc; b=jMwA9m25GSS2mszPm1+MmBpA9YzL5IYhEd/ybzcz4/dWFDhxM4spm0R08pozrubfUa1yHBkFyNn6v+1kBKXrRzlegvq5n9O0/9f+KoNPG2mrFrfw8BRy9NFWvaSXMK+FpZbVsQquoPbHfvUNeUyqtRzKuWRdsZtAV1HygqZG+zI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636103903; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+wN07j9w9qRHGjRgFRPkNW3MKwLIaZrWHDGPD0ZaZ1I=; b=K6KUHkrdEyhIDwPQbHYtO3Wvi7RaRHDOqFQxsZQ5DSsobMw36Cy8jX0xSXlMiXKUMr8y8dPDqIRXkWFmLhOLk9FHM0EQWv0DBxbY8XXr/iXrxu+QZw9PnTPRO2nDB2UC5iq2fx6pjlTGwWyN2UmXgtnWVpn8q3MFs0h3P0SusiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636103903928532.0710813848503; Fri, 5 Nov 2021 02:18:23 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-qbmLYh8WMuGRxP__-89Vhw-1; Fri, 05 Nov 2021 05:18:21 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0E815128; Fri, 5 Nov 2021 09:18:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 817CA68D7D; Fri, 5 Nov 2021 09:18:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3BC2A4E9F4; Fri, 5 Nov 2021 09:18:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A59IF70024878 for ; Fri, 5 Nov 2021 05:18:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9752B68D7D; Fri, 5 Nov 2021 09:18:15 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id E65E37944C for ; Fri, 5 Nov 2021 09:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636103902; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+wN07j9w9qRHGjRgFRPkNW3MKwLIaZrWHDGPD0ZaZ1I=; b=PcXJ0vzv3dwPDuDtwJqZJ9gyydgXPPU2fln06C5opEYAnOhBruiQNuuNMyO/0MhU1IwORR Sxd+jHaFAsI4RwKMzAFkD0W4viCmhbqilK3UX+GM8LeuH4be2NsentS0uXEMAa1E6csFcy BwTL7xfL01R4uMXO1ipEYcBMp7IeqnA= X-MC-Unique: qbmLYh8WMuGRxP__-89Vhw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] syntax-check: Fix regex for sc_require_attribute_cleanup_initialization: Date: Fri, 5 Nov 2021 10:17:55 +0100 Message-Id: <10d0352a68cded53e770799634e673017af3fcae.1636103875.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636103905645100001 Content-Type: text/plain; charset="utf-8" When I was cleaning up the regex after we removed most of our custom autofree helpers I've forgot to delete one closing brace, thus the regex was not matching anything. Fixes: 65f702020e8 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko Tested-by: J=C3=A1n Tomko --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 2a6e2f86a1..4d396699c9 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -910,7 +910,7 @@ sc_prohibit_backslash_alignment: # Rule to ensure that variables declared using a cleanup macro are # always initialized. sc_require_attribute_cleanup_initialization: - @prohibit=3D'((g_auto(ptr|free|slist)?)|VIR_AUTOCLOSE)) *[^=3D]+;' \ + @prohibit=3D'((g_auto(ptr|free|slist)?)|VIR_AUTOCLOSE) *[^=3D]+;' \ in_vc_files=3D'\.[chx]$$' \ halt=3D'variable declared with a cleanup macro must be initialized' \ $(_sc_search_regexp) --=20 2.31.1