From nobody Mon Feb 9 09:08:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680183709; cv=none; d=zohomail.com; s=zohoarc; b=Vtu/ZTQNxlTQyRy+ZmhzrJhZcO+YRX+MorUPd9Tw9UmwdgFN+xYeCqM+960fmGrPcm5VX/9Kh7EgxFvsDhg+99yaCv5PXwa/wcjdYkdP3m0nCRfJdp3Z2h539+yIPqqMkfnWdaCWQ8+M7bfcAzZJlyVD2oxySmDcS4f1d5STBOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680183709; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6EKfbFOft35S6KC02DHJtChJrNhfwiRt4qP0AmcP7zI=; b=GBucBV/wvZHQ+aAHoJVE5dvzkG6WZiH2cX6kRV2LR4/YUGt8YoOothuXFCxxhGbsmNImUs8hlQfv6tJsOMSwNsEdlcvdxhB34jbdzdnAP0tzAMbT4fZjlI9PjdcSx1+irnUulLEaWI3i/xT49H5wtNb1FUh7iqkHPxmxvPvoI/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1680183709775565.6928006569058; Thu, 30 Mar 2023 06:41:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-vrHVXue4OOuXhiCqQf1jXw-1; Thu, 30 Mar 2023 09:41:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 96FE8185A794; Thu, 30 Mar 2023 13:41:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 811E91121330; Thu, 30 Mar 2023 13:41:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A5655194F249; Thu, 30 Mar 2023 13:39:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6080A1946587 for ; Thu, 30 Mar 2023 13:38:52 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 52AB02166B34; Thu, 30 Mar 2023 13:38:52 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id C481D2166B33 for ; Thu, 30 Mar 2023 13:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680183708; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6EKfbFOft35S6KC02DHJtChJrNhfwiRt4qP0AmcP7zI=; b=Vn7DByjeOwesZJ1z6bEdipipZ7RuadQjXQqO6WUPy03GqWjfZRyX0fj5mLiPH7JCgmVT+Q 8v5ludklHfwf9v++MCkTHOb6N7UhaSHLW16+ET356vWD4zXiOOcNbpRGmgVu7uFituO5DQ eAxxMtgvJXxaNIIiMm2o+k4yOU1VgOA= X-MC-Unique: vrHVXue4OOuXhiCqQf1jXw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 26/31] qemuValidateDomainDefPSeriesFeature: Remove obsolete checks Date: Thu, 30 Mar 2023 15:38:20 +0200 Message-Id: <10b668268be29cef648cb57fc85d3959c47a2553.1680182808.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680184007965100001 Content-Type: text/plain; charset="utf-8" The features: QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE QEMU_CAPS_MACHINE_PSERIES_CAP_HTM QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC QEMU_CAPS_MACHINE_PSERIES_CAP_IBS are supported by all qemu versions that libvirt supports. Drop the obsolete checks. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 58 +--------------------------------------- 1 file changed, 1 insertion(+), 57 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b2624c9131..83e4ca757e 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -37,7 +37,6 @@ VIR_LOG_INIT("qemu.qemu_validate"); static int qemuValidateDomainDefPSeriesFeature(const virDomainDef *def, - virQEMUCaps *qemuCaps, int feature) { const char *str; @@ -69,25 +68,9 @@ qemuValidateDomainDefPSeriesFeature(const virDomainDef *= def, return -1; } } - - if (def->hpt_maxpagesize > 0 && - !virQEMUCapsGet(qemuCaps, - QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZ= E)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Configuring the page size for HPT guests " - "is not supported by this QEMU binary")); - return -1; - } break; case VIR_DOMAIN_FEATURE_HTM: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_CAP_HTM)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("HTM configuration is not supported by this " - "QEMU binary")); - return -1; - } - str =3D virTristateSwitchTypeToString(def->features[feature]); if (!str) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -98,13 +81,6 @@ qemuValidateDomainDefPSeriesFeature(const virDomainDef *= def, break; case VIR_DOMAIN_FEATURE_NESTED_HV: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED= _HV)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Nested HV configuration is not supported by " - "this QEMU binary")); - return -1; - } - str =3D virTristateSwitchTypeToString(def->features[feature]); if (!str) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -115,13 +91,6 @@ qemuValidateDomainDefPSeriesFeature(const virDomainDef = *def, break; case VIR_DOMAIN_FEATURE_CCF_ASSIST: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_AS= SIST)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("ccf-assist configuration is not supported by= " - "this QEMU binary")); - return -1; - } - str =3D virTristateSwitchTypeToString(def->features[feature]); if (!str) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -132,33 +101,8 @@ qemuValidateDomainDefPSeriesFeature(const virDomainDef= *def, break; case VIR_DOMAIN_FEATURE_CFPC: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC))= { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("cfpc configuration is not supported by " - "this QEMU binary")); - return -1; - } - - break; - case VIR_DOMAIN_FEATURE_SBBC: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC))= { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("sbbc configuration is not supported by " - "this QEMU binary")); - return -1; - } - - break; - case VIR_DOMAIN_FEATURE_IBS: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_PSERIES_CAP_IBS)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("ibs configuration is not supported by " - "this QEMU binary")); - return -1; - } - break; } @@ -197,7 +141,7 @@ qemuValidateDomainDefFeatures(const virDomainDef *def, case VIR_DOMAIN_FEATURE_CFPC: case VIR_DOMAIN_FEATURE_SBBC: case VIR_DOMAIN_FEATURE_IBS: - if (qemuValidateDomainDefPSeriesFeature(def, qemuCaps, i) < 0) + if (qemuValidateDomainDefPSeriesFeature(def, i) < 0) return -1; break; --=20 2.39.2