From nobody Fri Dec 19 04:18:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679146745; cv=none; d=zohomail.com; s=zohoarc; b=Tq6i0Bc2C99d5V7DrNo4VhC4uKirAfzBr5IiiWXpj+At1XVDhRG2IVsj8+TanFT2BzHUqAnuCvAXSBsoG3P2Ka7duExv8Uv0no2YqLSfATHKrsgSjVLZ7kHxO/DsnQQ4mWwppJGLq5ZbdPQRjFsEDy1Je2VOdk8K9YLhTQvVM+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679146745; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=t8EzCb/8v11L7HA5EZC8JqQqmhAYMzzuaTGEUmK71Xw=; b=NDcrs4UEukmSbTEVhRDEIvke1qMl7CN8xiA3EShaNE3STSCcA4tkvP0AVaS3utH/VzM+0anJJTM7/6aKwQHycQBFW8+q8k+tvJNCoZa8ceutKpnRInYj9RgmCGeBXKbV6xJtvrWCyKWbkf45o7tgk04K4X7OdjQtybFp9sef5hY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679146745949370.5955938686775; Sat, 18 Mar 2023 06:39:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-gA78xaQrNjaC87G6QHyTmQ-1; Sat, 18 Mar 2023 09:38:39 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90B862A59552; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F27C406AA66; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6D5CD1946A4B; Sat, 18 Mar 2023 13:38:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 89EEE1946595 for ; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6D8AB406AA66; Sat, 18 Mar 2023 13:38:33 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9DED406AA67 for ; Sat, 18 Mar 2023 13:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679146745; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=t8EzCb/8v11L7HA5EZC8JqQqmhAYMzzuaTGEUmK71Xw=; b=JLoWTqoMnqvsHqqx8RamvlS+g7l7Vfybk2OB7d9z+ia93jvfAcvC7+QejWFtIv5avSG3/y rrj4WDF1OVGKcg9eDjpNyUPCDJArX162MbAGOMMYPbYSXg0kyJ6ba25kBxz26ZngXpQVNP R81NjQPuqH1Ainv+vxE6Q5ZC8RZWokE= X-MC-Unique: gA78xaQrNjaC87G6QHyTmQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/8] util: xml: remove function names from error messages Date: Sat, 18 Mar 2023 14:38:25 +0100 Message-Id: <109b5adb1fcbad238b912cfede1c7e9fc0b5b154.1679146695.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679146746483100006 The function name is already logged, and these can happen only as a result of a programmer error. Signed-off-by: J=C3=A1n Tomko --- src/util/virxml.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index c0789c062c..a84048e14a 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -864,7 +864,7 @@ virXPathBoolean(const char *xpath, =20 if ((ctxt =3D=3D NULL) || (xpath =3D=3D NULL)) { virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Invalid parameter to virXPathBoolean()")); + "%s", _("Invalid parameter")); return -1; } obj =3D xmlXPathEval(BAD_CAST xpath, ctxt); @@ -917,7 +917,7 @@ virXPathNode(const char *xpath, =20 if ((ctxt =3D=3D NULL) || (xpath =3D=3D NULL)) { virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Invalid parameter to virXPathNode()")); + "%s", _("Invalid parameter")); return NULL; } obj =3D xmlXPathEval(BAD_CAST xpath, ctxt); @@ -952,7 +952,7 @@ virXPathNodeSet(const char *xpath, =20 if ((ctxt =3D=3D NULL) || (xpath =3D=3D NULL)) { virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Invalid parameter to virXPathNodeSet()")); + "%s", _("Invalid parameter")); return -1; } =20 --=20 2.39.2