From nobody Mon Feb 9 12:25:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643019002; cv=none; d=zohomail.com; s=zohoarc; b=Yw4Hnumcxp+S/Z/FfOXop6D+W3t+oFKNE364c8EgILVJg6ibWX/lj7uOIn4Hu6TvCpmgtGHjQdYrXx6R0Kg3Dg2W8qKspOe2ICmqQOWmjB5ujDXBhJJXQI0Ch/dcpboG+oZnr0ylexNBKghfs88cbfLncZjCDcQ3xhxisWbSCu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643019002; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ae9NULY/eeGXOxW+i8Mt98ZciAjjwx+8O0KHklwoXkM=; b=LyT/iqP9dqy0UIlFEF1izoT15iyvY31cXxmlJAMSR00xFroUVNgPF/UkB95qReruZHxq9vSW1Vu8Sc6vTJyeE+vg1rn4Up0z2cNud9ZCoQ9tGCHS/nU8O7FnRDRRXm6bDMIbw3ygsZwnFrlBUPV83rN32gqdShk+iqxpX+uoWuM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1643019002628985.9725477260682; Mon, 24 Jan 2022 02:10:02 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-oV-g6itFMfSNcYL0L696HQ-1; Mon, 24 Jan 2022 05:09:35 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A5A283DD21; Mon, 24 Jan 2022 10:09:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 596E57B9ED; Mon, 24 Jan 2022 10:09:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 280FE1806D1C; Mon, 24 Jan 2022 10:09:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20OA9SY2021614 for ; Mon, 24 Jan 2022 05:09:28 -0500 Received: by smtp.corp.redhat.com (Postfix) id A923A6F12B; Mon, 24 Jan 2022 10:09:28 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BCBB6F167 for ; Mon, 24 Jan 2022 10:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643019001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ae9NULY/eeGXOxW+i8Mt98ZciAjjwx+8O0KHklwoXkM=; b=DCulnLup17F7THdhWiiXboiWz3FuJmFPSkGlWzQX2s2cYDjNQqzE7MuKmwTDD+L4twIPFq /z9FUcEWqruT37EvcEMW/C9QTTIVyLloYg24eWn0vmreOCeUqccthAqAgGd0FDEdFIXtgC cirLn4nTGDuzhFDe7cnGq5G96KdnH48= X-MC-Unique: oV-g6itFMfSNcYL0L696HQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 10/11] virDomainTimerDefFormat: return void Date: Mon, 24 Jan 2022 11:07:32 +0100 Message-Id: <108aed6ae046c5a63fac78089010ea98a585cb8f.1643018556.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643019008565100001 Content-Type: text/plain; charset="utf-8" This function never returns an error, make it void then. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 55626a6d01..a5fa3acd32 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26100,7 +26100,7 @@ virDomainInputDefFormat(virBuffer *buf, } =20 =20 -static int +static void virDomainTimerDefFormat(virBuffer *buf, virDomainTimerDef *def) { @@ -26145,8 +26145,6 @@ virDomainTimerDefFormat(virBuffer *buf, =20 virXMLFormatElement(&timerChld, "catchup", &catchupAttr, NULL); virXMLFormatElement(buf, "timer", &timerAttr, &timerChld); - - return 0; } =20 static void @@ -28191,8 +28189,7 @@ virDomainDefFormatInternalSetRootName(virDomainDef = *def, virBufferAddLit(buf, ">\n"); virBufferAdjustIndent(buf, 2); for (n =3D 0; n < def->clock.ntimers; n++) { - if (virDomainTimerDefFormat(buf, def->clock.timers[n]) < 0) - return -1; + virDomainTimerDefFormat(buf, def->clock.timers[n]); } virBufferAdjustIndent(buf, -2); virBufferAddLit(buf, "\n"); --=20 2.34.1