From nobody Tue Sep 9 03:13:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747147485; cv=none; d=zohomail.com; s=zohoarc; b=fvmKK9n5/zo4YCNMcdJo+4+NeDz0IYQdkqdUGtZ7jq9SgAM1pUHKvjBa1FXEnUy0meH+qfpRsD9xfXqzrX+f3iqiW63zC8MUYioTGAo+lIo1JyPhDjfdYKOUvIbeCV3DQ+6OcN6qLW69rZ24pC+6m2vyhY1Z67AcLtIcHQ2uEC4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747147485; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=4gdW1wOxi+FPcGD/VU9m+j+11wCVse1EpHB6Tzqz8PY=; b=cawH1IBHiIPz+zUO99LOQOI7DdzqDNHnFmkS7PYlJTLUti/b296JQIQDgThTLnNn+bahnmbK4ZkfC0QD7C5gM1d//bGi021zhImqxuD6qtFUq73wAqGjjjbZdG1bYBshrhOuZ6ErpGS2LnF81S4Lot9U6KWdXmeC2LEpCDVJbCE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747147485648842.9186316908763; Tue, 13 May 2025 07:44:45 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CC7C0E6A; Tue, 13 May 2025 10:44:44 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C54E9E78; Tue, 13 May 2025 10:44:04 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 47870CBA; Tue, 13 May 2025 10:44:01 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DE4E8CB1 for ; Tue, 13 May 2025 10:44:00 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-xdKQisRrO5SEnL6uCOYkjw-1; Tue, 13 May 2025 10:43:59 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 66ED81801A0A for ; Tue, 13 May 2025 14:43:58 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A72D218003FC for ; Tue, 13 May 2025 14:43:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747147440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nbh6yuuTLD31xd7J1XI6s/fYYGYVn5QmLdcg6whYjCs=; b=NMlIUHVfU3CiwcL+xDbcOGdBDzDbxhd5ev8x/IBABMThlgIfen/6VfLyWm6RmvXmkawAlY C/qlWU2Aa0nOQXryXWP0+N5ee/6Qq8TPTz2ZYOhrsTlGFb0bRJCSX/o0b3P16vuvso5Okt VtbQbf38wdHGe6cKNKm2Jwt3vrdD+H0= X-MC-Unique: xdKQisRrO5SEnL6uCOYkjw-1 X-Mimecast-MFC-AGG-ID: xdKQisRrO5SEnL6uCOYkjw_1747147438 To: devel@lists.libvirt.org Subject: [PATCH v2 1/4] virnetlink: Provide stub for virNetlinkBridgeVlanFilterSet() Date: Tue, 13 May 2025 16:43:50 +0200 Message-ID: <1078f1a52e15112ce463c018ca7342e46c2d90f7.1747147293.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tXZ2Abg2FwDTtaKdO0zkfO3LPao7niFWnJ0IYCjLqUs_1747147438 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: J3OQMYIOXMU5BLE4AC264IHJJQHPOHYU X-Message-ID-Hash: J3OQMYIOXMU5BLE4AC264IHJJQHPOHYU X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747147489310019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik In virnetlink.c there are two sections: the first one when building WITH_LIBNL support, the other that provides stubs for functions declared in the corresponding header file when building without netlink support. But the stub implementation for virNetlinkBridgeVlanFilterSet() was missing. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/util/virnetlink.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 206646d9d7..e3fcabca15 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -1344,6 +1344,18 @@ virNetlinkNewLink(const char *ifname G_GNUC_UNUSED, } =20 =20 +int +virNetlinkBridgeVlanFilterSet(const char *ifname G_GNUC_UNUSED, + int cmd G_GNUC_UNUSED, + const unsigned short unusedflags G_GNUC_UNUS= ED, + const short vid G_GNUC_UNUSED, + int *error) +{ + *error =3D 0; + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); + return -1; +} + int virNetlinkGetNeighbor(void **nlData G_GNUC_UNUSED, uint32_t src_pid G_GNUC_UNUSED, --=20 2.49.0