From nobody Mon Feb 9 10:54:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1727703148935460.1209773163881; Mon, 30 Sep 2024 06:32:28 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CAF5012DF; Mon, 30 Sep 2024 09:32:27 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6DC2D14F3; Mon, 30 Sep 2024 09:30:05 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A47D112F8; Mon, 30 Sep 2024 09:29:58 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4D0901281 for ; Mon, 30 Sep 2024 09:29:47 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-oiUgI1qRPKq4fqYSfpkeZw-1; Mon, 30 Sep 2024 09:29:45 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F098318DB426 for ; Mon, 30 Sep 2024 13:29:44 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.12]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 37AC919541A0 for ; Mon, 30 Sep 2024 13:29:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727702986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rJ/dnPLAYoBpuJ+CjsbXOvGKxRRJjNcF1rFRzn2kbyU=; b=L4lPhfUdvrl/KcfsY4ARxuPnC/FQeAS/HXxPfk3UN7TBMg9qvL0WeGOLaRbautC4oM3DnO 1p2cZZ51gXtUmE/TV9WavqackQawJFx/4LhWe4eS3yW/wdCHdlWhF9GjKh3FEj1wZPoSws f/RZuK7UV+l42kOdlnDy76Z6QKN7bDE= X-MC-Unique: oiUgI1qRPKq4fqYSfpkeZw-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 06/13] virTypedParamsGetStringList: Ensure that returned string list is NULL-terminated Date: Mon, 30 Sep 2024 15:29:28 +0200 Message-ID: <102a4a2f387177b3c357d8b5eb963cda46a1d1c4.1727702835.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5MKWUXKFSOE5Y43GZAYFQIIYHGZEWZVF X-Message-ID-Hash: 5MKWUXKFSOE5Y43GZAYFQIIYHGZEWZVF X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1727703151144116600 Content-Type: text/plain; charset="utf-8" This can simplify callers who don't really need to know the number of elements to check that a particular element is present. Signed-off-by: Peter Krempa --- src/util/virtypedparam.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c index 564cb81acc..f25530a735 100644 --- a/src/util/virtypedparam.c +++ b/src/util/virtypedparam.c @@ -439,8 +439,8 @@ virTypedParamsFilter(virTypedParameterPtr params, * @values: array of returned values * * Finds all parameters with desired @name within @params and - * store their values into @values. If none of the @params are strings nam= ed - * @name the returned @values will be NULL. + * store their values into a NULL-terminated string list @values. If none = of + * the @params are strings named @name the returned @values will be NULL. * * Important: The strings in the returned string list @values are borrowed= from * @params and thus caller must free only the pointer returned as @values,= but @@ -465,7 +465,7 @@ virTypedParamsGetStringList(virTypedParameterPtr params, if (nfiltered =3D=3D 0) return 0; - *values =3D g_new0(const char *, nfiltered); + *values =3D g_new0(const char *, nfiltered + 1); for (i =3D 0; i < nfiltered; i++) { (*values)[i] =3D filtered[i]->value.s; --=20 2.46.0