From nobody Mon May 6 15:53:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1612830680; cv=none; d=zohomail.com; s=zohoarc; b=JklmNFvCAiXfeLobGqDN8e2loOvxC3jvMUvaXdtusTYmFV/VsE4rVsv5RLnY6Qn5CIMgEn9vNo0A+fxkrd6HlPXhaOiS6ZEOt3eHZmKMvHfWuNhwMlORXD/gp4lqJ2oQRInyj1XeXDnOp+snefZgMeDXYpTUMTU6DMLowpJmf6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612830680; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=h8hgSrqFiiPtZYvQMV88xSpuj50Aa8Ovi+HZiOADneo=; b=iEtZH1XoTuXG5jkp1jrZ117GQ6/sl2i8LoGOmit8LT99PWi/QFfAIZcHmIETy5qcC7ZP1sF2wYMoNQPpqyeSVlyH9+Z0t+VMo8dKSB4tfshP3GjkGh2dH/nOVQZGRxwKjpfzs2vX5dMkHkM+nWPs96pavuVGzUEp03du2pIF+ys= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612830680744680.1156209438211; Mon, 8 Feb 2021 16:31:20 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-_JZGQrP3PLKkcJvRt_ERfQ-1; Mon, 08 Feb 2021 19:31:17 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 489F8106BC6E; Tue, 9 Feb 2021 00:31:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10410648A0; Tue, 9 Feb 2021 00:31:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 859A718095CB; Tue, 9 Feb 2021 00:31:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1190V2oV024835 for ; Mon, 8 Feb 2021 19:31:02 -0500 Received: by smtp.corp.redhat.com (Postfix) id 595D52026D11; Tue, 9 Feb 2021 00:31:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 536062026D49 for ; Tue, 9 Feb 2021 00:31:00 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C625858F1B for ; Tue, 9 Feb 2021 00:31:00 +0000 (UTC) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-LrMyRNHyMLyADv6JbKsyTQ-1; Mon, 08 Feb 2021 19:30:57 -0500 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-11-WP-gjk2yPRyy_YDtFh4-qg-1; Tue, 09 Feb 2021 01:30:54 +0100 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR04MB4929.eurprd04.prod.outlook.com (2603:10a6:208:c8::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.27; Tue, 9 Feb 2021 00:30:53 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::bdae:2ddc:55e0:9099]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::bdae:2ddc:55e0:9099%5]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 00:30:53 +0000 Received: from [192.168.0.4] (75.169.41.71) by AM0PR04CA0102.eurprd04.prod.outlook.com (2603:10a6:208:be::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Tue, 9 Feb 2021 00:30:52 +0000 X-MC-Unique: _JZGQrP3PLKkcJvRt_ERfQ-1 X-MC-Unique: LrMyRNHyMLyADv6JbKsyTQ-1 X-MC-Unique: WP-gjk2yPRyy_YDtFh4-qg-1 To: LibVir From: Jim Fehlig Subject: tpm-tis device for ARM virt Message-ID: <0fa369ce-3ed0-6627-244a-6f07f7d92516@suse.com> Date: Mon, 8 Feb 2021 17:30:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 X-Originating-IP: [75.169.41.71] X-ClientProxiedBy: AM0PR04CA0102.eurprd04.prod.outlook.com (2603:10a6:208:be::43) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 777f6e3d-7854-4419-19a9-08d8cc91f542 X-MS-TrafficTypeDiagnostic: AM0PR04MB4929: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:197 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 2cW2IzCnLkz8j12+KP4fnSom4cbJxTgRYzNyREz47PDFaulMFF562UgbiyyTZnkK+G3mPvTBT80JncOku1DZ0B3bQHSmzS1KQpfdozOMcyppEKtT3kBn/dO3V/+kAr/FQCC/QZpy0ysU6nIA/U+3ohkL/DyGbmRGzvZfK2I47Madv/NUEApZsq05pA6kwt8WBWfd9NySQZlsyxa7vvgZwyQKk6gROOeLucgWxifFqUvqNPIkXLJAziidzHy+8BZhH64bJHif8KuOFrkHJhELoXbCJRLPAZi9j8rtqcSgsfQ9jsZMx/fteBtH1RoSjvIzDf1ztEpNBW9wm1cna5sDQxU508CeXE38hO4LfH7dUOTTbZxD08UxqwZlGMB3jUyBZksI7rTOAmea1tbTVLuYtRGDDL8VE8mw8gbIEWhdO+dzTRbJFXiqVbOxaKWtBf+BK5AxI0RCIqNXPhFQpvKadOenA5px2Bq84hhCKFr0xnftv+078oiwBKBOvGia+XYaJr6RA6tb+co7n3vh/VwixE+4rN9xvnYkKpqiWLyBzSbtvLVi7WueTGAVvxlYAuggt1TWO80Z+lW73wCq/XXmI0E5swz4CrWlhRo+0G3kqNBGaivcIeIUrCS0ECvjy81h6zlF+BfXpDmpCpVDRWHtuhg2O130nMIRaa0DYwDfYcfaEPaneo9nsFE31WWw4qCO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR04MB7970.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(39860400002)(396003)(136003)(346002)(5660300002)(186003)(16526019)(2906002)(6666004)(966005)(26005)(956004)(478600001)(52116002)(31686004)(2616005)(66476007)(316002)(16576012)(66946007)(66556008)(6916009)(36756003)(31696002)(86362001)(8676002)(8936002)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MGJrUUNEZG5qaklXeVNnUU1GakI5Y2grRHhpdTBnaHA3WVE4Y050Zmh0ZDNS?= =?utf-8?B?NzhKdWtZNVQ5TnJkcktpalVRV0ErVnBheEg2R3k2WXRySGJZZkwyODdnNWQw?= =?utf-8?B?YngvRWFzMDlsYTU4eUtXZVVNeGhuYWlvcGJVMDF5YXVvcVlXRDdkK1E4a0lB?= =?utf-8?B?MmVSeXE0b252Q2d0Nlc5TlBMR21ESEhsa09odWVvUDV2T3hObUEzU0FuNzhs?= =?utf-8?B?ZUZ3cmhJNVFZd09ocisycExzTlJwUHI1ZnZmZFV3Yi8rNC9KRXNFSy9UbWJM?= =?utf-8?B?bEpvT3JscnJWK28rR0o1bnlnbVRWRW0ybFBKR045UU1GY0FIQ0FabUUwQXJ3?= =?utf-8?B?dzZrVlFkVVhub1JjY1gwLzQ4UG42YVZGRE5MR0xSMlBlNitXVXYrKzE1eTQw?= =?utf-8?B?dWQ5akloRWtWTE0yTUFUQkNzekthaFp0ZzhORXFHMUhSYysyT1pFN2F4OS9k?= =?utf-8?B?YXR0UUtmeEVKbThQWjYvR3RDV2c3L25yMjBnRDVTSDRLT2NZU2F5TWt2R2t6?= =?utf-8?B?R1Y5QXFZWFJmTm5kYUExY1hFajB0OEtyTVgyQWR5RnVIRmFsNGt0c1B1Vndp?= =?utf-8?B?Q0tYeWNXTmtBSitkcXBiUFk4QVRlTExma2s3WkJqUWV5Y2h2VjhXcHJNK3NM?= =?utf-8?B?Z1hnVjdHc21oSEoxR3Y3VUZsejNNSTlaWTRsSHlDWGJZTHg5OXdFSk5pNFVE?= =?utf-8?B?UUdSZ2tORW1zenNlRms5dFc0L2xsMkhvNmdmWWlFNTR2bE5QYlZRNit0U1Yr?= =?utf-8?B?bTF4Y1V6UHdOQUJsNUVyYytuYmVRMXVjNVg3bG9MNEU0SXc0bnpqeWFrbFpG?= =?utf-8?B?OWx4b0wrQk8yaStaWHdZRzVGRjJqSFZQRDZJSDJ2UDA3L2YrSFRYUS9FWDdz?= =?utf-8?B?RVdaTExQMkpiRVRoRG9OcnhIZDJTSDNCRFo1TjZCK0lVeDlzOW5uNGpzaVFL?= =?utf-8?B?R0s3bHhTWDlSZFNmVFI4ejhpMVk2aWJ1MjBuTlhOQ3E3RitaV2l3ODJGRUth?= =?utf-8?B?RmRVQzlSS2ZjZVF3Y3hHR2hvWTlLMCtNY3IyV0wrV2RSSFNyaTBwbGEwbHFO?= =?utf-8?B?bGVzdVA4blY3d1R3c0FITVdJNE9Bb2lPV0o0dVpUcEtNcSt0RXd4OUd2TTVM?= =?utf-8?B?NnVjMnJiZ0lHV3l4YVNSbkpqbU5VSk9UOFp1Z1BOUGZxY1BNVWMyeDZ1TWpJ?= =?utf-8?B?dU4xTlhjU3VMcnloN2hwOWVvMWlNMTVyL3FDRHlwaVVFRXJsUXo2TWlHVkt1?= =?utf-8?B?cG1aekhJU0Zyb01pU3ZUS0tFT0dmM0ZCRmZvUSs3T3pVMzFtVUYxc1pOVHVs?= =?utf-8?B?WkVNZkxtTUFWR1pqcldiZjZFY253WSthSG42NHJsdWNONkJzTG1rOTBDQ20z?= =?utf-8?B?ejlabTRBNWJPUElOSWZwWVFNbTArVU9yczJ0bXVSOFBSY3B0K09oQnNiUTVN?= =?utf-8?B?NDdrcHpXeUJZRE1CeTNiNDFZSXZham9ZbFo1MjZNUG85Q1dCVVZrd3RoVGUz?= =?utf-8?B?Y2ZFYnpwUTZlSUpEVzlJOW1ReGJEWk1pc3NPOHhYS3Irb1hJZVRiUHc1ZCt2?= =?utf-8?B?dXJ1Y0lCdVkraWE5eHNRcmZ1UjVNYXBySXVhZEllRWh4c2Rka1hBZStkcWdo?= =?utf-8?B?bUZYNCtRMmtKaGhhWHVzU2xFdmJKaGVHS2NhSGs5aGlXUTNVTlVZV3VZdGx5?= =?utf-8?B?enhTN1lGS3g1R1drMGIweEpGZEZLRUtLWjBMZnZBZDN4dThXaVNsSERHejlU?= =?utf-8?Q?XxcM06b6wSSSDBeV6Azo/VBIsgsUnyyf9A7LbAk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 777f6e3d-7854-4419-19a9-08d8cc91f542 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 00:30:53.1223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d4S3lG2ALCTywsLwELFK7l573aF8V5bahOi/Mcce4cgItV++ZyQ9v4dnNHU6WeEivWPhr5/OToGWmx9Gpx+9FA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4929 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; format="flowed" Hi All, I received a private bug report that starting a VM with swtpm device fails = with=20 qemu-system-aarch64. The VM config has QEMU reports the following error error: internal error: process exited while connecting to monitor:=20 2021-02-07T05:15:35.378927Z qemu-system-aarch64: -device=20 tpm-tis,tpmdev=3Dtpm-tpm0,id=3Dtpm0: 'tpm-tis' is not a valid device model = name Indeed it appears the device name is 'tpm-tis-device' [1][2] for ARM virt. = The=20 similar yet different device naming between x86 and ARM is unfortunate. IIU= C,=20 the devices are the same between the architectures, i.e. they both emulate = a TPM=20 device conforming to the TIS spec. If so, adding a 'tpm-tis-device' to=20 virDomainTPMModel seems redundant. I assume the naming difference should be=20 handled internally, e.g. something like the below patch to qemuBuildTPMDevS= tr? I=20 can send a proper patch if this is an acceptable approach. Regards, Jim [1] https://qemu.readthedocs.io/en/latest/specs/tpm.html [2] https://github.com/qemu/qemu/commit/c294ac327ca99342b90bd3a83d2cef9b447= afaa7 diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 92036d26c0..5154611ccd 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9198,6 +9198,9 @@ qemuBuildTPMDevStr(const virDomainDef *def, g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; const char *model =3D virDomainTPMModelTypeToString(tpm->model); + if (tpm->model =3D=3D VIR_DOMAIN_TPM_MODEL_TIS && def->os.arch =3D=3D = VIR_ARCH_AARCH64) + model =3D "tpm-tis-device"; + virBufferAsprintf(&buf, "%s,tpmdev=3Dtpm-%s,id=3D%s", model, tpm->info.alias, tpm->info.alias);