From nobody Sun Feb 8 18:43:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593416651; cv=none; d=zohomail.com; s=zohoarc; b=itEsnKxfIoS5L6kKlG7cNwMNobLppR0O8RxvDK1fpRZZaBGCloImhxXQn9cBnRVxVcMpkGxM6Ta54pmpcN8pSbshQ6FDQ9kxf07jNE3tDeUNFroYxkn666fZhijLTBVf4sQkhULIw1eDUJ+bOvWNRFMz1lMof8wqSM/arxRWwZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593416651; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x6R8EzmHyNu2wRDc3thdGcenjsI+G+VWlXlLydaldn4=; b=nz10yhnr+SGOA3cfamvThrE1XqkSlS6px3xirw79u3Si7rZ+73YgFuSZXn7fA2rvINyR8SV+8sRNwKygAGUjROW9+paIS0rqe842gfyFSePAp901UBbzPpjbD7TdgWpNGN/XNKt0cq+inkur9CeScjQ+fmYAVGBUAYux0exxgPM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1593416651984924.11717330993; Mon, 29 Jun 2020 00:44:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-iXHkNJ4yP4Wa7W54HOH27w-1; Mon, 29 Jun 2020 03:44:08 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 038D6802ED4; Mon, 29 Jun 2020 07:44:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5E7C9CFEB; Mon, 29 Jun 2020 07:44:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A26C21809557; Mon, 29 Jun 2020 07:44:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05T7hiec004555 for ; Mon, 29 Jun 2020 03:43:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3F3885C1D4; Mon, 29 Jun 2020 07:43:44 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4DD65C1BD for ; Mon, 29 Jun 2020 07:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593416650; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=x6R8EzmHyNu2wRDc3thdGcenjsI+G+VWlXlLydaldn4=; b=anehk+b1xz45nmQPMn+IEwjLNrk3Z4rUjaK72eMe7bs0zXfIttCTz/6Kl/0ULG0omqrrvb EK6YsezxmcfHEX8IxUgCwnQOjl9BtO5aWyjyfYTkG4okRg+VquwzrG9m87NmBx/k9cKSFC 5c1FAx5KffpFK0ttR/Te/u0gweX1HWo= X-MC-Unique: iXHkNJ4yP4Wa7W54HOH27w-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/3] qemuhotplugtest: Free monitor iff successfully initialized Date: Mon, 29 Jun 2020 09:43:36 +0200 Message-Id: <0ec1c5c20fcd6c6072d1e386d3070767a481b6cd.1593416559.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" If initializing test monitor in testQemuHotplugCpuPrepare() fails, the control jumps to error label where testQemuHotplugCpuDataFree() is called. But since the data->mon is NULL due to aforementioned failure, qemuMonitorTestGetMonitor() dereferences a NULL pointer leading to a SIGSEGV. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- tests/qemuhotplugtest.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index ba3fc4d814..ba30cf5aa6 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -399,9 +399,11 @@ testQemuHotplugCpuDataFree(struct testQemuHotplugCpuDa= ta *data) virObjectUnref(data->vm); } =20 - mon =3D qemuMonitorTestGetMonitor(data->mon); - virObjectLock(mon); - qemuMonitorTestFree(data->mon); + if (data->mon) { + mon =3D qemuMonitorTestGetMonitor(data->mon); + virObjectLock(mon); + qemuMonitorTestFree(data->mon); + } VIR_FREE(data); } =20 --=20 2.26.2