From nobody Mon Feb 2 07:30:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1768924552; cv=none; d=zohomail.com; s=zohoarc; b=E68kt1XuE9GaaVtGNDoI0vMcfWpgwv8gHtV/UnEeVORZ7SOMAHGay3Rs8wDrwLasQNqXknW7MaGGT98lCkwIanmpxux24/Mpa3AkfZUDKj/SZjVey3G0Eh8+i7TVfe3yujgQMrBOJtPiZ2FXOSwIPt8Np5ithNwggc6ZilchZEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768924552; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=E6pmKDgwK2JbXAJeNSXIbpwjg7QZs2n5P+JYU4zzJoY=; b=hAyD7P0yc54vOFiVb5mYZE/A8eKDPl7Sl2ehV3Jmv/CIKb/rXf1Ym7ESjbmErT8cLAnvyDUQ3ANgNTlphoq8U84XxntxbrZVd8c6KDBtp02l+Jm2b4MRBrS2bzEXuab2c1RH95LB+b+0VsIz90KQUmsBJpej4acpZ5UcW43k27Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1768924552394327.9952545362205; Tue, 20 Jan 2026 07:55:52 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 8159B41C4D; Tue, 20 Jan 2026 10:55:51 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 760C043E50; Tue, 20 Jan 2026 10:54:29 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 1E36C41A2B; Tue, 20 Jan 2026 10:54:24 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9B3C8417E1 for ; Tue, 20 Jan 2026 10:54:23 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-Qaqxh2cDOI-3AakzfPsoUg-1; Tue, 20 Jan 2026 10:54:22 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B4EB180034A for ; Tue, 20 Jan 2026 15:54:21 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8F24E18004D8 for ; Tue, 20 Jan 2026 15:54:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768924463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6pmKDgwK2JbXAJeNSXIbpwjg7QZs2n5P+JYU4zzJoY=; b=J7Ek2SU8smpiZLEui1SIFuz0ZsGd70R7SaxRuTQoFM8Q8WxonpFhHRK+p9BEvJZZjE53mJ NzomDyEB1QYbZKbxVWfHG+73yZv2iRSHgJ7YYu8FOHw4C1lA7/9QM/8Jjr15YZ7a3HECCA PUs7IVAtfjsY6MmWzlrGl4Jz3Q4T+fQ= X-MC-Unique: Qaqxh2cDOI-3AakzfPsoUg-1 X-Mimecast-MFC-AGG-ID: Qaqxh2cDOI-3AakzfPsoUg_1768924461 To: devel@lists.libvirt.org Subject: [PATCH 1/2] libvirt-domain: Fix documentation of virDomainInterfaceAddresses() Date: Tue, 20 Jan 2026 16:54:15 +0100 Message-ID: <0e6a28901f46d3f189d56dcef6382209bc136ae9.1768924441.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gYOELJdCPSe6RMCHb2-2VB7JQCJKSLbstKyhFa_bnVU_1768924461 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GYJDD5U23ZUO2FYQHMIOAM7KKVBTDQ3W X-Message-ID-Hash: GYJDD5U23ZUO2FYQHMIOAM7KKVBTDQ3W X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1768924553227158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Ever since of v1.2.14-rc1~105 the hwaddr member of _virDomainInterface struct can be NULL. And this is documented inside the struct. But then the public API documents it can never be NULL which is obviously wrong. Fix the public API documentation. Fixes: 3640245db7d72bf8e05df726587625a6328c895e Signed-off-by: Michal Privoznik --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 74c70a0a43..a278c4679d 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12881,7 +12881,7 @@ virDomainFSInfoFree(virDomainFSInfoPtr info) * might be unset (e.g. VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP does not * set IP address prefix as ARP table does not have any notion of that). * - * @ifaces->name and @ifaces->hwaddr are never NULL. + * @ifaces->name is never NULL, and @ifaces->hwaddr may be NULL. * * The caller *must* free @ifaces when no longer needed. Usual use case * looks like this: --=20 2.52.0