[PATCH] qemucapabilitiesdata: Fix command name in caps_3.0.0.ppc64.replies

Michal Privoznik posted 1 patch 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/0d4ff9dd980ab3de19bba49faf92b08bf0a2385c.1639729768.git.mprivozn@redhat.com
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] qemucapabilitiesdata: Fix command name in caps_3.0.0.ppc64.replies
Posted by Michal Privoznik 2 years, 3 months ago
Under the qemucapabilitiesdata we have a replies file for
QEMU-3.0.0.ppc64. At least we think so. In fact, the file
contains replies from a development snapshot release that
predates 3.0.0 (specifically it's v2.12.0-1689-g518d23a) and as
such does not reflect any change that was made to QEMU after the
snapshot and before the official relase. One of such changes was
renaming 'exit-preconfig' command to 'x-exit-preconfig' (QEMU
commit v3.0.0-rc1~21^2~3). Ideally, we would just regenerate
capabilities using the official release but since this is a PPC64
machine and pretty old version anyway let's just fix the command
name.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies
index 3df67b71de..c12ee7814e 100644
--- a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies
+++ b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies
@@ -1296,7 +1296,7 @@
       "arg-type": "0"
     },
     {
-      "name": "exit-preconfig",
+      "name": "x-exit-preconfig",
       "ret-type": "0",
       "allow-oob": false,
       "allow-preconfig": true,
@@ -12327,7 +12327,7 @@
       "name": "system_wakeup"
     },
     {
-      "name": "exit-preconfig"
+      "name": "x-exit-preconfig"
     },
     {
       "name": "cont"
-- 
2.32.0

Re: [PATCH] qemucapabilitiesdata: Fix command name in caps_3.0.0.ppc64.replies
Posted by Peter Krempa 2 years, 3 months ago
On Fri, Dec 17, 2021 at 09:29:38 +0100, Michal Privoznik wrote:
> Under the qemucapabilitiesdata we have a replies file for
> QEMU-3.0.0.ppc64. At least we think so. In fact, the file
> contains replies from a development snapshot release that
> predates 3.0.0 (specifically it's v2.12.0-1689-g518d23a) and as
> such does not reflect any change that was made to QEMU after the
> snapshot and before the official relase. One of such changes was
> renaming 'exit-preconfig' command to 'x-exit-preconfig' (QEMU
> commit v3.0.0-rc1~21^2~3). Ideally, we would just regenerate
> capabilities using the official release but since this is a PPC64
> machine and pretty old version anyway let's just fix the command
> name.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>