From nobody Mon Feb 2 07:29:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1768405108; cv=none; d=zohomail.com; s=zohoarc; b=KLbLuc8nWP1rNaeE8Sxk+cq57yaZf3GqFwpvwGd2GOLwApHRVMHi86akeTKt9BJ9Kd12ErXL4pjbnMly8DJS53r8v9BtvJYVcO8uNsu/JLRS3hfmZ7bweckAwqXC8fdBdjQ3qoXGtfNXZ5FVXOm4G+Am9hlgTYIbV92hcvyv6Z0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768405108; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=/7hvy9OhEvjGQY8u4Duh54GKqrwF7ti9mLlegj6+ki8=; b=eJlJsjGgjxlKAJFStg4zehwdmkFahxrdz1K7EvI0ekfd4vcrpf6MoovFBc5aTue5EOb9PHsVBhZekmoePgVhTMDhH0A15zoCveOAz2ZCBS+ZzDmrERDbRIETCK01RB0Ur/pisifEDm3D69dxhErLUblAGI2/JTYcTMYDRM6khJo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17684051082146.995774171314679; Wed, 14 Jan 2026 07:38:28 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 65EF341ACB; Wed, 14 Jan 2026 10:38:27 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1AE3241C92; Wed, 14 Jan 2026 10:35:57 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6F4AA3F358; Wed, 14 Jan 2026 10:35:39 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DB2773F361 for ; Wed, 14 Jan 2026 10:35:38 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-hn74CDcdMPSCvTq0pfM1lQ-1; Wed, 14 Jan 2026 10:35:36 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 187C51956095 for ; Wed, 14 Jan 2026 15:35:36 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 751A230002D8 for ; Wed, 14 Jan 2026 15:35:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768404938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/7hvy9OhEvjGQY8u4Duh54GKqrwF7ti9mLlegj6+ki8=; b=AmkbK8CBI81hNkg5nHP7JwAo3cJbdYc2A7aab2HVmgiPazZ/36zo00nZYuyp2A8bVBRM5I s4vd2Wj90ZWz6Q5nFlunKdX+LRHSO2xApfwXFyU1De2l7TbBcXvcm0mUGzDKxBEVSJlgV4 8otwb9tn5k9St4oi0Bvr8t1SH2Lr9pM= X-MC-Unique: hn74CDcdMPSCvTq0pfM1lQ-1 X-Mimecast-MFC-AGG-ID: hn74CDcdMPSCvTq0pfM1lQ_1768404936 To: devel@lists.libvirt.org Subject: [PATCH 2/3] qemu: Call virSecurityManagerLoadProfile() at the end of qemuProcessPrepareDomain() Date: Wed, 14 Jan 2026 16:35:30 +0100 Message-ID: <0cf6af8ca34e8db070d68666ebfd8277e709052c.1768404892.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IZ7rHay0yw47YwY1J4xruyIn8JOkQCONPKK80hoxJfE_1768404936 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VIHK7RZGWWNRWISM7IW7U375DJLCINNU X-Message-ID-Hash: VIHK7RZGWWNRWISM7IW7U375DJLCINNU X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1768405110118158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik So far, this is a NOP as no secdriver implements the callback. But the idea is to separate seclabel generation on profile loading for AppArmor. See next commit. Signed-off-by: Michal Privoznik --- src/qemu/qemu_process.c | 7 +++++++ src/qemu/qemu_security.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index a53bb40783..5d5b1b291b 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7154,6 +7154,13 @@ qemuProcessPrepareDomain(virQEMUDriver *driver, } } =20 + /* Keep this as the last step so that security drivers can + * see all the path generated in steps above. */ + if (!(flags & VIR_QEMU_PROCESS_START_PRETEND)) { + if (qemuSecurityManagerLoadProfile(driver->securityManager, vm->de= f) < 0) + return -1; + } + return 0; } =20 diff --git a/src/qemu/qemu_security.h b/src/qemu/qemu_security.h index 36663cffde..d540c01f77 100644 --- a/src/qemu/qemu_security.h +++ b/src/qemu/qemu_security.h @@ -137,6 +137,7 @@ int qemuSecurityCommandRun(virQEMUDriver *driver, #define qemuSecurityGetMountOptions virSecurityManagerGetMountOptions #define qemuSecurityGetNested virSecurityManagerGetNested #define qemuSecurityGetProcessLabel virSecurityManagerGetProcessLabel +#define qemuSecurityManagerLoadProfile virSecurityManagerLoadProfile #define qemuSecurityNew virSecurityManagerNew #define qemuSecurityNewDAC virSecurityManagerNewDAC #define qemuSecurityNewStack virSecurityManagerNewStack --=20 2.52.0