From nobody Mon Feb 9 07:55:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563467528; cv=none; d=zoho.com; s=zohoarc; b=cbKAqRNXEcBC0H7icnUYyjAZ82LNjva1OHqQoKTmxO+Hp4NFX9RDrMmIfA3d3DYLDRFckqvYkcsEGNZBYJzgETi8LVqwUL1DiJ+Gt6mw+vMZtR5E9LNXSTA+AKBSVM8wAXDmSSj1H7eb1UXksP9SRadDRF+A6HpZoBsgceu1k04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563467528; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=xKaodhhCWOiwsGDU72lt1wp6fdgcWDXnWZAWqXXlNxs=; b=RdhmUAoMKyS6NSzIVA+MGy2KU/SAIuupvd8Svm1rlVARZIgwNs1FYQlC7pxG2+Cv7AFzCtRWBJrQpFdA6+mJzU3qw95ZDXl0FF4nVNQCOnCR6wdYecVUbCKfpmn3d8kHt8joP+kZGwKbfAKGW5Svlgg7o53hsx7ZvP26vBZBsyQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563467528760443.99868986000945; Thu, 18 Jul 2019 09:32:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0279130C746E; Thu, 18 Jul 2019 16:32:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2EFA5D71A; Thu, 18 Jul 2019 16:32:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 75F8D3CBB; Thu, 18 Jul 2019 16:32:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6IGVpdu005203 for ; Thu, 18 Jul 2019 12:31:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0BF37608A6; Thu, 18 Jul 2019 16:31:51 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A19060A35 for ; Thu, 18 Jul 2019 16:31:50 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Thu, 18 Jul 2019 18:31:40 +0200 Message-Id: <0cf022ef535605751a9bc69db308cc846af82e86.1563467440.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/8] qemu: driver: Report error if pivoting fails in qemuDomainBlockJobAbort X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 18 Jul 2019 16:32:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" As the error message is now available and we know whether the job failed we can report an error straight away rather than having the user check the event. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 39b5ea5e7e..7a69a0e084 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17230,6 +17230,21 @@ qemuDomainBlockJobAbort(virDomainPtr dom, } qemuBlockJobUpdate(vm, job, QEMU_ASYNC_JOB_NONE); } + + if (pivot && + job->state =3D=3D QEMU_BLOCKJOB_STATE_FAILED) { + if (job->errmsg) + virReportError(VIR_ERR_OPERATION_FAILED, + _("block job '%s' failed while pivoting"), + job->name); + else + virReportError(VIR_ERR_OPERATION_FAILED, + _("block job '%s' failed while pivoting: %s= "), + job->name, NULLSTR(job->errmsg)); + + ret =3D -1; + goto endjob; + } } endjob: --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list