From nobody Mon Feb 9 05:00:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627031174; cv=none; d=zohomail.com; s=zohoarc; b=f+oq+BGftmnnzT26ux+HOWuMTG8x1hxQU6r1zBgpix4rbAzNpqZfh/ZivmExZ55sWfy957EgnWv3zc+gMGuHhMQ6DVSL/tGRzaURDBxJMvKFcFMjj/lYmm5ntpAqeUzO2AhCpEJMnTSX0rBW75vEuHY783qV++yfl4IWMF0VLe4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627031174; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lXbjhxDLMGKQmnwNI2pYIR8RmXCZvVB4abI6nqfbul4=; b=kRGe6LASyO7ZzTLJMz3wOEk9IYYpCcSzbVCf8uvNdxI+VFkjz0u60tTOF2a1QhdCCcayIz6m50QjBYzuHUkU/RUY3QzxCyj78HZ/4z4G9YGBdvUAc/SFzSXg0DyYCsSbcIMyjyngxzySGj8ooUm1SSUGQoj+aYePysyRxswLx+4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627031174101738.4359007978017; Fri, 23 Jul 2021 02:06:14 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-SxDZ-sAiONGXDNQ1VbQ_jg-1; Fri, 23 Jul 2021 05:06:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 031C41084F5D; Fri, 23 Jul 2021 09:06:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1FE35C23A; Fri, 23 Jul 2021 09:06:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 91100180140E; Fri, 23 Jul 2021 09:06:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16N9615o019577 for ; Fri, 23 Jul 2021 05:06:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1E45960853; Fri, 23 Jul 2021 09:06:01 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76E7760862 for ; Fri, 23 Jul 2021 09:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627031173; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lXbjhxDLMGKQmnwNI2pYIR8RmXCZvVB4abI6nqfbul4=; b=iVCBP+epDJppJk0C8BO+i2wncgcNI7Ye9xZqUM5VvmMTlviNHwrtbgBx8hWIPak+ksk6Dq Q/q7htdDFQucGO6SH6VLhw3V0kWbakjddI9JbTwUD03ijQYFx4RUIa1PSK4UzIdMLOIGGe TdQXqLftPI4tTtyncUemWZuuRaY5GJU= X-MC-Unique: SxDZ-sAiONGXDNQ1VbQ_jg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/7] virNetworkObjNew: Remove impossible error handling Date: Fri, 23 Jul 2021 11:05:48 +0200 Message-Id: <0c508af20ad8afe089e38eafca5e4648f1dc445b.1627031076.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627031174835100003 Content-Type: text/plain; charset="utf-8" 'obj->classIdMap' is a bitmap with size of '16', thus the first 3 bits are guaranteed to be available. Use 'virBitmapSetBit' instead of 'virBitmapSetBitExpand' since we don't need any expansion and ignore errors as they are impossible. Signed-off-by: Peter Krempa --- src/conf/virnetworkobj.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index ea021892c7..2a2d94dc98 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -112,21 +112,16 @@ virNetworkObjNew(void) obj->classIdMap =3D virBitmapNew(INIT_CLASS_ID_BITMAP_SIZE); - /* The first three class IDs are already taken */ - if (virBitmapSetBitExpand(obj->classIdMap, 0) < 0 || - virBitmapSetBitExpand(obj->classIdMap, 1) < 0 || - virBitmapSetBitExpand(obj->classIdMap, 2) < 0) - goto error; + /* The first three class IDs are already taken. */ + ignore_value(virBitmapSetBit(obj->classIdMap, 0)); + ignore_value(virBitmapSetBit(obj->classIdMap, 1)); + ignore_value(virBitmapSetBit(obj->classIdMap, 2)); obj->ports =3D virHashNew(virNetworkObjPortFree); virObjectLock(obj); return obj; - - error: - virObjectUnref(obj); - return NULL; } --=20 2.31.1