From nobody Sat Feb 7 07:15:12 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710157527619820.3881284460394; Mon, 11 Mar 2024 04:45:27 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5E7B31F7E; Mon, 11 Mar 2024 07:45:26 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A42D11DD5; Mon, 11 Mar 2024 07:32:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AB7271D01; Mon, 11 Mar 2024 07:31:10 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9E68919C0 for ; Mon, 11 Mar 2024 07:31:09 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-532-kF241-pTMRavF4Dcv-LabA-1; Mon, 11 Mar 2024 07:31:08 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE101101CC67 for ; Mon, 11 Mar 2024 11:31:07 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36966111DCF3 for ; Mon, 11 Mar 2024 11:31:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: kF241-pTMRavF4Dcv-LabA-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 06/23] virsh: Remove uncommon redundant descriptions of virsh commands Date: Mon, 11 Mar 2024 12:30:43 +0100 Message-ID: <0c3cca3ef47c2f73651683ec13f4417fef404d0a.1710156504.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: ARRJ7UDDOWLVFDE62JWZZH4VM3TEOQ5D X-Message-ID-Hash: ARRJ7UDDOWLVFDE62JWZZH4VM3TEOQ5D X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710157528414100001 Some description of virsh commands referenced itself in a multi-line example of usage, which is pointless as virsh help already shows how to use the command: .data =3D N_("Get or set the current memory parameters for a guest" " domain.\n" " To get the memory parameters use following command: \n= \n" " virsh # memtune ") Change it to just state what the command does and leave the example for the help printer. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 20 ++++---------------- tools/virsh-host.c | 4 +--- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d3e28f38f4..a90aefeb32 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1528,10 +1528,7 @@ static const vshCmdInfo info_blkiotune[] =3D { .data =3D N_("Get or set blkio parameters") }, {.name =3D "desc", - .data =3D N_("Get or set the current blkio parameters for a guest" - " domain.\n" - " To get the blkio parameters use following command: \n= \n" - " virsh # blkiotune ") + .data =3D N_("Get or set the current blkio parameters for a guest dom= ain.") }, {.name =3D NULL} }; @@ -9257,10 +9254,7 @@ static const vshCmdInfo info_memtune[] =3D { .data =3D N_("Get or set memory parameters") }, {.name =3D "desc", - .data =3D N_("Get or set the current memory parameters for a guest" - " domain.\n" - " To get the memory parameters use following command: \= n\n" - " virsh # memtune ") + .data =3D N_("Get or set the current memory parameters for a guest do= main.") }, {.name =3D NULL} }; @@ -9432,10 +9426,7 @@ static const vshCmdInfo info_perf[] =3D { .data =3D N_("Get or set perf event") }, {.name =3D "desc", - .data =3D N_("Get or set the current perf events for a guest" - " domain.\n" - " To get the perf events list use following command:= \n\n" - " virsh # perf ") + .data =3D N_("Get or set the current perf events for a guest domai= n.") }, {.name =3D NULL} }; @@ -9564,10 +9555,7 @@ static const vshCmdInfo info_numatune[] =3D { .data =3D N_("Get or set numa parameters") }, {.name =3D "desc", - .data =3D N_("Get or set the current numa parameters for a guest" - " domain.\n" - " To get the numa parameters use following command: \n\= n" - " virsh # numatune ") + .data =3D N_("Get or set the current numa parameters for a guest doma= in.") }, {.name =3D NULL} }; diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 90ff46c5c4..87443220bd 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -1505,9 +1505,7 @@ cmdVersion(vshControl *ctl, const vshCmd *cmd G_GNUC_= UNUSED) static const vshCmdInfo info_node_memory_tune[] =3D { {"help", N_("Get or set node memory parameters")}, - {"desc", N_("Get or set node memory parameters\n" - " To get the memory parameters, use following command: = \n\n" - " virsh # node-memory-tune")}, + {"desc", N_("Get or set node memory parameters")}, {NULL, NULL} }; --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org