From nobody Wed Dec 17 08:54:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1745846552; cv=none; d=zohomail.com; s=zohoarc; b=jyuKQVrL/d1rlWyi1tiakH9AO9K783i1gQ4M4MxvUTzD91wDq9Bnh/LMg6uFpaCiJA8GQmBWYVLTugPM6XNaqe4Em3vUP0U098Ah1YdH3QvTY6/Cw7JSzwteCZX16mhyBaLkjV0GPcOGTHq0B55SbR9j3bAq+0VbjD9ZjjiEeEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1745846552; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=DEweFFfJNMJm1D1CUMj0Q9Y2qEseIy7dOjuNLMHJoE8=; b=hVn31Iocqs8rQg4Czwc1YIlALFB+KZqVSj9jUcOASRx1DvypvQhQe62CG0ASJiGHGpLeRxXcJftB5NuRjMlSTN1H5q18HMkzan0y4ESTd2y7edQBc3zRhXNdwi7d3NuUqfo0CZB6q8h7E5xemGzbAP5JrtwXPdxWqyx8l5sLtm4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745846552357891.2595815640733; Mon, 28 Apr 2025 06:22:32 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4B547D45; Mon, 28 Apr 2025 09:22:31 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EAC04B6B; Mon, 28 Apr 2025 09:21:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 66520996; Mon, 28 Apr 2025 09:21:11 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 18DD1B24 for ; Mon, 28 Apr 2025 09:21:09 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-4iRy-dmuOFiBgV7lb_ecBQ-1; Mon, 28 Apr 2025 09:21:06 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DB3CA195608B for ; Mon, 28 Apr 2025 13:21:05 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 43C2F19560A3 for ; Mon, 28 Apr 2025 13:21:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745846468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRKGlWRcJP/6251eGgn4OWFkSlj4ta1QsL4ldMAQXCc=; b=XYWrbyTSwQZf9OCvGXbALlfBt3ms2TcyOMMd0YN5l/gmVDfFDmlsckCCD7CAQjz1qMWDEt hqE02BgP4va8J8dhCULZsLxsBCAFmD6L4CfXNBDXLvdbd6w0rDW2ePezVHeTopIFoK2OKy 5ZHxHlnhlXvHdITZbQwMjhn5MQychWM= X-MC-Unique: 4iRy-dmuOFiBgV7lb_ecBQ-1 X-Mimecast-MFC-AGG-ID: 4iRy-dmuOFiBgV7lb_ecBQ_1745846466 To: devel@lists.libvirt.org Subject: [PATCH 3/3] scripts: Adapt mock-noinline.py to ATTRIBUTE_NOIPA Date: Mon, 28 Apr 2025 15:20:58 +0200 Message-ID: <0a89faeeff24dc452d9ff20cb0b0a2be842f0b89.1745846174.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Xya5klM28XtwsEc99pqlrgtmAp6Eklzr-gDT2OyV2fk_1745846466 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BZJ7K43AM3GNWMETQQMU7MRWE7X3C376 X-Message-ID-Hash: BZJ7K43AM3GNWMETQQMU7MRWE7X3C376 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745846554571019100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The script is renamed to mock-noipa.py and adjusted to check for the new attribute. Signed-off-by: Michal Privoznik --- build-aux/syntax-check.mk | 4 ++-- scripts/meson.build | 2 +- scripts/{mock-noinline.py =3D> mock-noipa.py} | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) rename scripts/{mock-noinline.py =3D> mock-noipa.py} (93%) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index d414e033df..16a28241db 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1326,9 +1326,9 @@ sc_spacing-check: $(PERL) $(top_srcdir)/build-aux/check-spacing.pl || \ { echo 'incorrect formatting' 1>&2; exit 1; } =20 -sc_mock-noinline: +sc_mock-noipa: $(AM_V_GEN)$(VC_LIST_EXCEPT) | $(GREP) '\.[ch]$$' | $(RUNUTF8) \ - $(PYTHON) $(top_srcdir)/scripts/mock-noinline.py + $(PYTHON) $(top_srcdir)/scripts/mock-noipa.py =20 sc_header-ifdef: $(AM_V_GEN)$(VC_LIST_EXCEPT) | $(GREP) '\.[h]$$' | $(RUNUTF8) xargs \ diff --git a/scripts/meson.build b/scripts/meson.build index 2798e302ab..bc38277dbf 100644 --- a/scripts/meson.build +++ b/scripts/meson.build @@ -29,7 +29,7 @@ scripts =3D [ 'meson-install-web.py', 'meson-python.sh', 'meson-timestamp.py', - 'mock-noinline.py', + 'mock-noipa.py', 'prohibit-duplicate-header.py', 'qemu-replies-tool.py', ] diff --git a/scripts/mock-noinline.py b/scripts/mock-noipa.py similarity index 93% rename from scripts/mock-noinline.py rename to scripts/mock-noipa.py index 77a5ca23e2..66a5f38bdc 100755 --- a/scripts/mock-noinline.py +++ b/scripts/mock-noipa.py @@ -22,7 +22,7 @@ import sys noninlined =3D {} mocked =3D {} =20 -# Functions in public header don't get the noinline annotation +# Functions in public header don't get the noipa annotation noninlined["virEventAddTimeout"] =3D True # This one confuses the script as its defined in the mock file # but is actually just a local helper @@ -43,7 +43,7 @@ def scan_annotations(filename): elif line.isspace(): func =3D None =20 - if "G_NO_INLINE" in line: + if "ATTRIBUTE_NOIPA" in line: if func is not None: noninlined[func] =3D True =20 @@ -74,7 +74,7 @@ warned =3D False for func in mocked.keys(): if func not in noninlined: warned =3D True - print("%s is mocked at %s but missing 'G_NO_INLINE' annotation" % + print("%s is mocked at %s but missing 'ATTRIBUTE_NOIPA' annotation= " % (func, mocked[func]), file=3Dsys.stderr) =20 if warned: --=20 2.49.0