From nobody Mon Apr 29 03:33:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627319273; cv=none; d=zohomail.com; s=zohoarc; b=LUyb5opAXlz/mXCrYorRw1bQ/BhYvBe1YkHE6ibKcyNzHHco9NQZF3kJoy/9OjNb2c5MW5VjwaVu29Hl8v7qgtAYnmb8KqkXtBGaCTZaU39WXjk0UU5PjhIz6S47dO09BPglkIPdmhiGjAgQJfHJVGoNuR3gvVIURGqBOc+g5ds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627319273; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JX1X0iI92mEhKhqIyV1joOvC9b9Z8L1DVF98DHBOiro=; b=FCwD7dyLtUXVk5ybfFjHIIs5napiB3rRwJ2jEHFj5xwh2OcUcGs0OLsfyB3xp4vEKbCffweXY703jHYZNgOENJEYi4CN9rlxmRdAx5GBOjJhYsykPpwWBGPIsUMM9wNmScP0lIje9gy8OnjQi39NzYF+/eJE4R8B6/74d3l2hUE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627319273480131.35791720749546; Mon, 26 Jul 2021 10:07:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-t3tHqGTWPFmnLhlXSVsS5A-1; Mon, 26 Jul 2021 13:07:50 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82750107ACF5; Mon, 26 Jul 2021 17:07:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE61419D7C; Mon, 26 Jul 2021 17:07:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 738961806D0F; Mon, 26 Jul 2021 17:07:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16QH7cbV022008 for ; Mon, 26 Jul 2021 13:07:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 032C21ABD2; Mon, 26 Jul 2021 17:07:38 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 815611ABD1 for ; Mon, 26 Jul 2021 17:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627319272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JX1X0iI92mEhKhqIyV1joOvC9b9Z8L1DVF98DHBOiro=; b=GvNFvir+UOx3dxTZR3RyDOZsXjpS6o74+wieA6UZewY3UzSTWmw9Dh0csDP3pUklwbFMb7 onuatSLP8w+1eGoeCIXpWpmeBsHXw3oZGhVw4Yq75rjdcv8uuar5wN7E3jLobZ0uBRJSI9 kgDE31IWGkxgI3DA3BimOy8fOQYYgmk= X-MC-Unique: t3tHqGTWPFmnLhlXSVsS5A-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: monitor: remove destroy callback Date: Mon, 26 Jul 2021 19:07:32 +0200 Message-Id: <0a71a9b008935f113e922192775cd9ca236f2100.1627319249.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627319275216100001 It was added by commit c2121602 and later removed by 5a4c2374a Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/qemu/qemu_monitor.c | 2 -- src/qemu/qemu_monitor.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 6e2d8010c5..5d7b686136 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -233,8 +233,6 @@ qemuMonitorDispose(void *obj) =20 VIR_DEBUG("mon=3D%p", mon); qemuMonitorDisposed =3D true; - if (mon->cb && mon->cb->destroy) - (mon->cb->destroy)(mon, mon->vm, mon->callbackOpaque); virObjectUnref(mon->vm); =20 g_main_context_unref(mon->context); diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 1491c1297c..05ec228800 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -363,7 +363,6 @@ typedef void (*qemuMonitorDomainMemoryFailureCallback)(= qemuMonitor *mon, =20 typedef struct _qemuMonitorCallbacks qemuMonitorCallbacks; struct _qemuMonitorCallbacks { - qemuMonitorDestroyCallback destroy; qemuMonitorEofNotifyCallback eofNotify; qemuMonitorErrorNotifyCallback errorNotify; qemuMonitorDomainEventCallback domainEvent; --=20 2.31.1