[libvirt PATCH] qemu: monitor: remove destroy callback

Ján Tomko posted 1 patch 2 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/0a71a9b008935f113e922192775cd9ca236f2100.1627319249.git.jtomko@redhat.com
src/qemu/qemu_monitor.c | 2 --
src/qemu/qemu_monitor.h | 1 -
2 files changed, 3 deletions(-)
[libvirt PATCH] qemu: monitor: remove destroy callback
Posted by Ján Tomko 2 years, 8 months ago
It was added by commit c2121602 and later removed by 5a4c2374a

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_monitor.c | 2 --
 src/qemu/qemu_monitor.h | 1 -
 2 files changed, 3 deletions(-)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 6e2d8010c5..5d7b686136 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -233,8 +233,6 @@ qemuMonitorDispose(void *obj)
 
     VIR_DEBUG("mon=%p", mon);
     qemuMonitorDisposed = true;
-    if (mon->cb && mon->cb->destroy)
-        (mon->cb->destroy)(mon, mon->vm, mon->callbackOpaque);
     virObjectUnref(mon->vm);
 
     g_main_context_unref(mon->context);
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index 1491c1297c..05ec228800 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -363,7 +363,6 @@ typedef void (*qemuMonitorDomainMemoryFailureCallback)(qemuMonitor *mon,
 
 typedef struct _qemuMonitorCallbacks qemuMonitorCallbacks;
 struct _qemuMonitorCallbacks {
-    qemuMonitorDestroyCallback destroy;
     qemuMonitorEofNotifyCallback eofNotify;
     qemuMonitorErrorNotifyCallback errorNotify;
     qemuMonitorDomainEventCallback domainEvent;
-- 
2.31.1

Re: [libvirt PATCH] qemu: monitor: remove destroy callback
Posted by Peter Krempa 2 years, 8 months ago
On Mon, Jul 26, 2021 at 19:07:32 +0200, Ján Tomko wrote:
> It was added by commit c2121602 and later removed by 5a4c2374a
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_monitor.c | 2 --
>  src/qemu/qemu_monitor.h | 1 -
>  2 files changed, 3 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>