From nobody Mon Feb 9 09:08:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604495124; cv=none; d=zohomail.com; s=zohoarc; b=m2e02fYoW1Zb0groyxBWtpLlwjCySYNs+H5jxmaJeGWH6zu4Rs0eYTJa7Wdk3YbQqDZ9jp9j8W2YffSXSmy726m257CfMiS3LJK1ra80lwObbAKuGdAUW/NMUfhhtzTThNh4ZvdUikAeJWvVdqtar7ifTCXn1TQoaI8nse8Efww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604495124; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q8Aj1TDAHolnzz5bXTneGz5spfhRGIcEajZtWCXsirA=; b=ROEZXKXtlMpUK3iW6Cu61xCr11pgMlqbBiNfGWxRRkBZenJUhqzeT8uf3PbY+vsqgLVwDOBGf+aRwS4su3+1hSPTTnjrM0vO0DRCWefGW2nKfKQTpIushSuTaLpmJcFB/6cr/k9BNbXUAbN8taPM40hB0ZdVqPcF85nJgsG54wY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604495124749688.4210143448836; Wed, 4 Nov 2020 05:05:24 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-wOpgRuCmMgS7pJ5wXHWdGw-1; Wed, 04 Nov 2020 08:05:18 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6479100F963; Wed, 4 Nov 2020 13:05:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE19E10589B0; Wed, 4 Nov 2020 13:05:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 869908C7B0; Wed, 4 Nov 2020 13:05:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A4D5AP6002896 for ; Wed, 4 Nov 2020 08:05:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id B8AB01C6; Wed, 4 Nov 2020 13:05:10 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0551E5C640 for ; Wed, 4 Nov 2020 13:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604495121; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Q8Aj1TDAHolnzz5bXTneGz5spfhRGIcEajZtWCXsirA=; b=JkDNukDZGrQyzwakBe1XV9fzXtaOvVpwQWfvz4hGxdc5+WELn7xqITJDYWy3wgInP5rNqB LPMilPqOHqWHmGsJh4R0VFm6Q6ImGRqtzqASHvlQIay48gg5beA1xbmYwHPb3JR9w2TIlv k6aSDUakjraB2ufIj8pzTXwBixDpjFY= X-MC-Unique: wOpgRuCmMgS7pJ5wXHWdGw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/9] checkpoint: Mention that VIR_DOMAIN_CHECKPOINT_XML_SIZE may require running vm Date: Wed, 4 Nov 2020 14:04:59 +0100 Message-Id: <0a3e2f14c7aec64053f78098430cbb8070559b08.1604495066.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The qemu implementation requires that the VM associated with the checkpoint is running when checking the size. Mention this possibility with the flag. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/libvirt-domain-checkpoint.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libvirt-domain-checkpoint.c b/src/libvirt-domain-checkpoin= t.c index 8a7b55dcd2..e9af8e4cf0 100644 --- a/src/libvirt-domain-checkpoint.c +++ b/src/libvirt-domain-checkpoint.c @@ -192,7 +192,9 @@ virDomainCheckpointCreateXML(virDomainPtr domain, * attribute that shows an estimate of the current size in bytes that * have been dirtied between the time the checkpoint was created and the * current point in time. Note that updating the size may be expensive and - * data will be inaccurate once guest OS writes to the disk. + * data will be inaccurate once guest OS writes to the disk. Also note that + * hypervisors may require that the domain associated with @checkpoint is + * running when VIR_DOMAIN_CHECKPOINT_XML_SIZE is used. * * Returns a 0 terminated UTF-8 encoded XML instance or NULL in case * of error. The caller must free() the returned value. --=20 2.26.2