From nobody Mon Feb 9 04:04:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1691059023; cv=none; d=zohomail.com; s=zohoarc; b=HotzFw3wdoUyPXGH8CgW/+VNas2LAn4QOkzCOVMXuUFHz/zUiQwSxRJReuLSbzaqA/a+sl7qHuOUTuFY3BiC7fbymRjR4ugU0os121wTmOw462vx3vzrCIlWcI8LinUpEfyWI0IOqDDgLvC9K/lfGQQM7XU5jyqmfX553L+IDxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691059023; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eZuViPOXhIOtTl1DCp61Y+whQDNKPZ3VMxCtWnWyQ00=; b=lAIXueLk9MdZF3613o4BC+c3j9ktxik56S1zeIrviBAUO3tSXdaWWoK5BeXbbK0sSmBl+eodcyJ99lkzXkrQt3idwONTgwS1tYQOJXshTxza+eOxg5J7aoT2hGmFJO9D9h8ZlFhiNhNEyljHx52ntIUe24J/zlmmmN2KzLd49ZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1691059023326428.2628249840068; Thu, 3 Aug 2023 03:37:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-rc-y_G2UOuyiIP0WFlxXHQ-1; Thu, 03 Aug 2023 06:36:33 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 921BB8870D5; Thu, 3 Aug 2023 10:36:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D7CD492CAC; Thu, 3 Aug 2023 10:36:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A011F1946A78; Thu, 3 Aug 2023 10:36:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 679C219451C5 for ; Thu, 3 Aug 2023 10:36:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 5D199F7FA6; Thu, 3 Aug 2023 10:36:26 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0443AF77BD for ; Thu, 3 Aug 2023 10:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691059022; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eZuViPOXhIOtTl1DCp61Y+whQDNKPZ3VMxCtWnWyQ00=; b=KUDbV3zlBsoREBjJmAyuQD3hN/cQ0sQf4HDY3+f0O4JRfMP+AC3JXTZ7S2qQqjRxkNjEDx YMdI/5LjaABDYYy3Xma2/4HybAgz3mexvgV7Tg1iT9Okh/pwUq5u/AjI28I9NbV/CPUojy XjB+RZiCAo4P34C8XEN+xEXq7HGzsg0= X-MC-Unique: rc-y_G2UOuyiIP0WFlxXHQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 06/13] virfirewalld: Drop useless memset() in virFirewallDApplyRule() Date: Thu, 3 Aug 2023 12:36:13 +0200 Message-ID: <090087d6f4373a863068ce306b1a8f32fba28c5f.1691058853.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1691059024298100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This is a residue of v6.8.0-rc1~100. The error variable inside of virFirewallDApplyRule() is already initialized to NULL. There's no need to memset() it to zero again. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana --- src/util/virfirewalld.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 6fc54f357d..827e201dbb 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -360,8 +360,6 @@ virFirewallDApplyRule(virFirewallLayer layer, if (!sysbus) return -1; =20 - memset(&error, 0, sizeof(error)); - if (!ipv) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unknown firewall layer %1$d"), --=20 2.41.0