From nobody Mon Feb 9 05:01:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584457545; cv=none; d=zohomail.com; s=zohoarc; b=WFl47SOFWYbzqp22DD6GHPgPok8sVHPGc+hKsfi8UC6cznn74derC3+3pHDRosGLg2X+0mJHxYiOfkECiQBKrpnvL/tbvsXPREbzjfOagKOlUlgB5rWDEq/q1NbNV6lVbNHRIdK5GtwAX++VHFiZoOh0OgdyzgtpFqR8yaMomFQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584457545; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZKt+gIO8TVTRTDHIXo5bFvA18AwleiE+Pjnxw8Fboxk=; b=ELPoNn6XMGz3GImderl7JWfvpjr8mlpAtQ5DVH5a/5rM1rPLlTLdpHgKawDapJe/vIlUo/zK/gFIX1odoWDnMg4jKNYXWTcK2zrPXxZBVO/HMkxkHpsknK5X7htjpK8RGCouoyAMho63ZWkB0nm26dpo15t9GewpUl6y5jAampQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1584457545848810.4267358641225; Tue, 17 Mar 2020 08:05:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-qCYbDgjsMhKqLC-1C6m_xQ-1; Tue, 17 Mar 2020 11:05:42 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B11941857BE4; Tue, 17 Mar 2020 15:05:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7812F1001DC2; Tue, 17 Mar 2020 15:05:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 047288700F; Tue, 17 Mar 2020 15:05:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02HF5M9P004556 for ; Tue, 17 Mar 2020 11:05:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id BBBDD5C219; Tue, 17 Mar 2020 15:05:22 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41D705C1D8 for ; Tue, 17 Mar 2020 15:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584457544; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZKt+gIO8TVTRTDHIXo5bFvA18AwleiE+Pjnxw8Fboxk=; b=WMJ2aCh4zyBLagwvWipNCzhp4m3nXGV0esb+Ujt0hrfsnAY9gIKM6ItcKhi4ZPD5PBql5o D4SRu3b0juMMAArxmqKGw2k0XQ+tHqfdQWKzRSEJSRFPVk1qt4PeLXm7WCeV10PNk547HU lMNzNEGd3k9EXpFV7WClzfqeLnsvU2U= X-MC-Unique: qCYbDgjsMhKqLC-1C6m_xQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/3] qemuBlockBitmapsHandleCommitFinish: Use proper variable to iterate Date: Tue, 17 Mar 2020 16:05:14 +0100 Message-Id: <07e085052d1a5852f8d8e8b6292ab94d6980d2f6.1584457464.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The function repeatedly checked the first element rather than interating through the array. Reported-by: Daniel P. Berrang=C3=A9 Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 115682c39d..f95ebb6fa7 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3177,7 +3177,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSourcePt= r topsrc, char **disabledbitmaps; for (disabledbitmaps =3D disabledBitmapsBase; *disable= dbitmaps; disabledbitmaps++) { - if (STREQ(*disabledBitmapsBase, bitmap->name)) { + if (STREQ(*disabledbitmaps, bitmap->name)) { bitmapdata =3D g_new0(struct qemuBlockBitmapsH= andleCommitData, 1); bitmapdata->create =3D false; --=20 2.24.1