From nobody Sun Feb 8 21:42:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614701569; cv=none; d=zohomail.com; s=zohoarc; b=CQ/zKPO2VahXcnBx8ELaZPhnfFl7BPkTHMWz7L96DaPOjTlc+sKwm6Qbc9Uu2OjoAqaJqn9I5EKgNbcV48p5Grg1wowO7SA9Fg5VDF0LpzETBh9MopolKLk2Z7Nt6XpzzgfBIlrpQ2icncv2bcwraCcc7hvx+nL4tzCCXU4R/XY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614701569; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7NhiXOM4VsHPAwgW21xAtYlqHSy4rYeqjClHu9sUdXI=; b=Pfvpy2CHiut4Z4r2CVz+kFXtLUpmwXwhHEzqu4c7kCE3+Iv2vUbpEQbO+/EtgcWW2XWryJ2XU0LuId4tmIGR2ANn/foTTt9Fau1IoYnm1sJuSQJEUtwOQtGsqpbyxRXv/rXiovut8CiKuE1feb8KS/GJwnCo9HNMwASbRK9oqlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1614701569495539.5943480732171; Tue, 2 Mar 2021 08:12:49 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98--YKQz8TcNU2gurld0AKkBQ-1; Tue, 02 Mar 2021 11:12:46 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14712801980; Tue, 2 Mar 2021 16:12:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E05F56F991; Tue, 2 Mar 2021 16:12:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A4D3D58079; Tue, 2 Mar 2021 16:12:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 122GCQin024059 for ; Tue, 2 Mar 2021 11:12:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id C06AE60C47; Tue, 2 Mar 2021 16:12:26 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3437360BFA for ; Tue, 2 Mar 2021 16:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614701568; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7NhiXOM4VsHPAwgW21xAtYlqHSy4rYeqjClHu9sUdXI=; b=jHqxVVzwABJt9i/c9RkL/3QrCjY/rqFBDLzCxuZfB3u/ofqwW0tRbF+xbo4mRtApMuDURY s1l5ITd7VXjj1t+aFbKHrYhvKiWA0BwkX68OYHzdA4J45c1HL85Z/lx8v1Sx8C7kxIYrMa T2+Pm6W5GCjRnqgJIhBtHnLSBDYVQRM= X-MC-Unique: -YKQz8TcNU2gurld0AKkBQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 6/6] commandtest: test27: Remove pointless 'cleanup' label Date: Tue, 2 Mar 2021 17:12:08 +0100 Message-Id: <075a5316673a45548069a21a7eadde4053dc5d86.1614701477.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/commandtest.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index 524c959eba..aaf391935c 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -1041,7 +1041,6 @@ static int test27(const void *unused G_GNUC_UNUSED) g_autoptr(virCommand) cmd =3D virCommandNew(abs_builddir "/commandhelp= er"); int buf1fd; int buf2fd; - int ret =3D -1; size_t buflen =3D 1024 * 128; g_autofree char *buffer0 =3D NULL; g_autofree char *buffer1 =3D NULL; @@ -1093,29 +1092,25 @@ static int test27(const void *unused G_GNUC_UNUSED) if (virCommandRun(cmd, NULL) < 0) { printf("Cannot run child %s\n", virGetLastErrorMessage()); - goto cleanup; + return -1; } if (!outactual || !erractual) - goto cleanup; + return -1; if (STRNEQ(outactual, outexpect)) { virTestDifference(stderr, outexpect, outactual); - goto cleanup; + return -1; } if (STRNEQ(erractual, errexpect)) { virTestDifference(stderr, errexpect, erractual); - goto cleanup; + return -1; } if (checkoutput("test27") < 0) - goto cleanup; - - ret =3D 0; - - cleanup: + return -1; - return ret; + return 0; } --=20 2.29.2