From nobody Sun Feb 8 21:12:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614676395; cv=none; d=zohomail.com; s=zohoarc; b=ejNf7b0zu73itBH/XFYmYj+Drq/179UMiavK6ne4v9B4HK9IPqRkB1g5wR1a3Hrzq3RY4he2DghtcSZWonzW/spOXtZ0o+QusqJaMiuDUtNRB5s89b2ixVGsc3fTVW95C3VHPQlLegnUp6cVRjXNjiT/SI/L0/KxFB/aKAAjST4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614676395; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vm8jNsXEoVXBCif5aVxSpGC87AygcokVRi31QXGePoQ=; b=HDKWJU+03BJve5HjR+wsBEsWFmxi06Ap/C05PTk2lwnuwsjscgKMc+wHINT0bO9cjNEVW9z8ng9GgtHzvQIO7AwUBWJDOUc6uo2D6wn9v6AF45iRzdptzVUJiH7nUZMugfCuyUgUb3PMGwyi5F1fQQVrTEh+yooQ5vuyetJCbk0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1614676395501547.446983640845; Tue, 2 Mar 2021 01:13:15 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-ru00Kd4tPzGzRGF5Dh4_uA-1; Tue, 02 Mar 2021 04:13:12 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D46C283DCCD; Tue, 2 Mar 2021 09:13:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B3AF5D766; Tue, 2 Mar 2021 09:13:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D96A118095CB; Tue, 2 Mar 2021 09:13:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1229D4I5008962 for ; Tue, 2 Mar 2021 04:13:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id 859595D9F1; Tue, 2 Mar 2021 09:13:04 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id E044F5D9E8 for ; Tue, 2 Mar 2021 09:13:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614676394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Vm8jNsXEoVXBCif5aVxSpGC87AygcokVRi31QXGePoQ=; b=g+Q6dUIQnoaOPr6wrEEAgXAuoyF0JlGA5H3jgiyfpOof7yuBGneCvIShwpJSPW+dW1ge/q G20LMWPizdcs7ZtPN9kyqs+fTpp/8FwopPE2aMuqYQiQG7JnGKr7lOyM5+i3TEkXFX7tKp wJA2AOmo1vUx8ttTwiFYMRmkuRbWEzE= X-MC-Unique: ru00Kd4tPzGzRGF5Dh4_uA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/2] lib: Debug print all arguments of virNetworkUpdate() Date: Tue, 2 Mar 2021 10:12:56 +0100 Message-Id: <07166903d582a54aeaaabed33b6af752c40ae973.1614675201.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Somehow, command argument was not printed into debug logs. It is imperative that all arguments are logged. Signed-off-by: Michal Privoznik --- src/libvirt-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-network.c b/src/libvirt-network.c index 92bdbacbff..b84389f762 100644 --- a/src/libvirt-network.c +++ b/src/libvirt-network.c @@ -530,8 +530,8 @@ virNetworkUpdate(virNetworkPtr network, unsigned int flags) { virConnectPtr conn; - VIR_DEBUG("network=3D%p, section=3D%d, parentIndex=3D%d, xml=3D%s, fla= gs=3D0x%x", - network, section, parentIndex, xml, flags); + VIR_DEBUG("network=3D%p, command=3D%d, section=3D%d, parentIndex=3D%d,= xml=3D%s, flags=3D0x%x", + network, command, section, parentIndex, xml, flags); =20 virResetLastError(); =20 --=20 2.26.2