[libvirt] [PATCH] Drop \n at the end of VIR_DEBUG messages

Jiri Denemark posted 1 patch 5 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/06a437e355fd1775c1518cebe48326c485ccfad0.1537257552.git.jdenemar@redhat.com
Test syntax-check failed
src/conf/capabilities.c    | 2 +-
src/util/virrotatingfile.c | 4 ++--
tests/virnetsockettest.c   | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
[libvirt] [PATCH] Drop \n at the end of VIR_DEBUG messages
Posted by Jiri Denemark 5 years, 6 months ago
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/conf/capabilities.c    | 2 +-
 src/util/virrotatingfile.c | 4 ++--
 tests/virnetsockettest.c   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index 326bd15cee..85f538e8c4 100644
--- a/src/conf/capabilities.c
+++ b/src/conf/capabilities.c
@@ -691,7 +691,7 @@ virCapabilitiesDomainDataLookupInternal(virCapsPtr caps,
                               machinetype, machine->name, NULLSTR(machine->canonical));
                     continue;
                 }
-                VIR_DEBUG("Match machine type machine %s\n", NULLSTR(machinetype));
+                VIR_DEBUG("Match machine type machine %s", NULLSTR(machinetype));
 
                 foundmachine = machine;
                 break;
diff --git a/src/util/virrotatingfile.c b/src/util/virrotatingfile.c
index ca62a8e026..d7dc3bd1ce 100644
--- a/src/util/virrotatingfile.c
+++ b/src/util/virrotatingfile.c
@@ -484,7 +484,7 @@ virRotatingFileWriterAppend(virRotatingFileWriterPtr file,
         if ((file->entry->pos == file->maxlen && len) ||
             forceRollover) {
             virRotatingFileWriterEntryPtr tmp;
-            VIR_DEBUG("Hit max size %zu on %s (force=%d)\n",
+            VIR_DEBUG("Hit max size %zu on %s (force=%d)",
                       file->maxlen, file->basepath, forceRollover);
 
             if (virRotatingFileWriterRollover(file) < 0)
@@ -571,7 +571,7 @@ virRotatingFileReaderConsume(virRotatingFileReaderPtr file,
 {
     ssize_t ret = 0;
 
-    VIR_DEBUG("Consume %p %zu\n", buf, len);
+    VIR_DEBUG("Consume %p %zu", buf, len);
     while (len) {
         virRotatingFileReaderEntryPtr entry;
         ssize_t got;
diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c
index 5927be1f80..7f52bf5c61 100644
--- a/tests/virnetsockettest.c
+++ b/tests/virnetsockettest.c
@@ -161,7 +161,7 @@ testSocketIncoming(virNetSocketPtr sock,
                    void *opaque)
 {
     virNetSocketPtr *retsock = opaque;
-    VIR_DEBUG("Incoming sock=%p events=%d\n", sock, events);
+    VIR_DEBUG("Incoming sock=%p events=%d", sock, events);
     *retsock = sock;
 }
 
-- 
2.19.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Drop \n at the end of VIR_DEBUG messages
Posted by Pavel Hrdina 5 years, 6 months ago
On Tue, Sep 18, 2018 at 09:59:12AM +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/conf/capabilities.c    | 2 +-
>  src/util/virrotatingfile.c | 4 ++--
>  tests/virnetsockettest.c   | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list