From nobody Mon Feb 9 05:00:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565793213; cv=none; d=zoho.com; s=zohoarc; b=kXMM5leH7WBbKcgjjHl/8gEAjYt3rA1nGvGg0Iw7CFQpbbyZ8JteCgwglHwBPLQiYw8ikqkXbJiYjtptdi6UyUyfAiOe/GDCY7zK9xeb8yI5Kx6EaDTvG1dTqK3gvPTQrTo119bGYz4tm5XvH+bTLRgS2r24uPrXZBGNIFvUJpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565793213; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ybDqC2mpI4/7A45K2+hw2H5rQGypdTj26Z3rS4o5r+0=; b=aDzSvGqdTCA1r7yz3rE2dHHq7l8cMLCJWQcddt2RJlhRATfuLFl2txEOb1G2qaoxeKb1LqS6FRCHySjOdIrBYdI+wq7dxK5bATKahHr9QrLhBb/GqWP1venvCC22SvgUUcO1zx/teeEWuIq/W8FUvvTb6KTYnOv0LsfjGLn67MU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156579321394474.35813527355731; Wed, 14 Aug 2019 07:33:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CD93309843B; Wed, 14 Aug 2019 14:33:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33A7585A53; Wed, 14 Aug 2019 14:33:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1029324F30; Wed, 14 Aug 2019 14:33:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7EEXUr1022516 for ; Wed, 14 Aug 2019 10:33:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8F55C546E0; Wed, 14 Aug 2019 14:33:30 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A2083ACA for ; Wed, 14 Aug 2019 14:33:29 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 14 Aug 2019 16:33:19 +0200 Message-Id: <065384455b53c6b122ce610704a82d8231a7578f.1565790969.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/5] virUUIDFormat: s/VIR_UUID_RAW_LEN/VIR_UUID_BUFLEN/ in comment X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 14 Aug 2019 14:33:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The function takes raw UUID and formats it into string representation. However, the comment mistakenly states that the expected size of raw UUID buffer is VIR_UUID_RAW_LEN bytes. We don't have such constant since v0.3.2~24. It should have been VIR_UUID_BUFLEN. Signed-off-by: Michal Privoznik Reviewed-by: Jiri Denemark --- src/util/viruuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/viruuid.c b/src/util/viruuid.c index 0c12ddcc3e..8930a0e199 100644 --- a/src/util/viruuid.c +++ b/src/util/viruuid.c @@ -141,7 +141,7 @@ virUUIDParse(const char *uuidstr, unsigned char *uuid) =20 /** * virUUIDFormat: - * @uuid: array of VIR_UUID_RAW_LEN bytes to store the raw UUID + * @uuid: array of VIR_UUID_BUFLEN bytes to store the raw UUID * @uuidstr: array of VIR_UUID_STRING_BUFLEN bytes to store the * string representation of the UUID in. The resulting string * will be NULL terminated. --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list