From nobody Mon Aug 24 09:08:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1786621951; cv=none; d=zohomail.com; s=zohoarc; b=PhGK6W0duo0E3T+TPks56+XOMi+YHyvgEQGnKkMSTSb4skpjW6bNZrM6APqPUsX1kskjI7Enpf4KC7zcYTOk+OYcugDeMSbTajD16MnNbnrr8Bb/iNNiCtZMdwr1wigTF9HrLyZ1bdI4HuMs4cqBsZph/dxg3kQAamBRJEDJivE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786621951; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=clDp6HCw/j5fJA4MDDewdUxtxbDLEOChC1WMnFWaa6Q=; b=EJkhL7b3JRvylXG3IVepC8UMpbYl3kKCozIuugRoGyL1hG03rPZ24alEC25exiuAoCuE4vEciyIM08pmtpvPDbMjCIDGZw+zqEaHbB+/7XP4myezhzSzsRlFMYzx4RvkjHHnim8sU08Mu0TzxYJrYu52DKYwpCV8aM0niZZiyWc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1786621950923220.70120439152151; Thu, 13 Aug 2026 04:52:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 778913F321; Thu, 13 Aug 2026 07:52:29 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 1AB88418DA; Thu, 13 Aug 2026 07:51:37 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B21353F33A; Thu, 13 Aug 2026 07:51:25 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A22AD417D7 for ; Thu, 13 Aug 2026 07:51:23 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-kp-Q4Qc2Ms2S9kI6wzSmvQ-1; Thu, 13 Aug 2026 07:51:21 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB8C118001E2 for ; Thu, 13 Aug 2026 11:51:20 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1803B180049F for ; Thu, 13 Aug 2026 11:51:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786621883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=clDp6HCw/j5fJA4MDDewdUxtxbDLEOChC1WMnFWaa6Q=; b=PeSjnG0/XFipEsoZnueQnzgWRE8FAuR7HmBiDEDByeJp0Jdrjzb5vZQ8AfJwkhSnFx1BD+ 43chBLietrFyVjC+rTmZd7D9mJzkBGxTJ/L3SNsx/BLNrGFo/TIeiIe19U3OcFHw7oaP+c M9FCYYWTvDpvP3xSOep0le2v1iUhc50= X-MC-Unique: kp-Q4Qc2Ms2S9kI6wzSmvQ-1 X-Mimecast-MFC-AGG-ID: kp-Q4Qc2Ms2S9kI6wzSmvQ_1786621880 To: devel@lists.libvirt.org Subject: [PATCH] gitlab: Fix printing of installed packages for 'potfile' job Date: Thu, 13 Aug 2026 13:51:17 +0200 Message-ID: <0565e65aa2570ea91fca816f377e5b5a319d881c.1786621877.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OAIPzZymiy4SP8y29y2zOrdnh8q-Gdi1zF7ioEHApxc_1786621880 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: STX76SH7I2NDTZ62ZIEYQ2LJES4DTXAD X-Message-ID-Hash: STX76SH7I2NDTZ62ZIEYQ2LJES4DTXAD X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1786621953828158500 From: Michal Privoznik YAML specification does not allow duplicate keys [1]: JSON's RFC4627 requires that mappings keys merely =E2=80=9CSHOULD=E2=80= =9D be unique, while YAML insists they =E2=80=9CMUST=E2=80=9D be. Technically, Y= AML therefore complies with the JSON spec, choosing to treat duplicates as an error. And while gitlab's documentation is a bit relaxed [2] it only masks the problem: When there are duplicate keys, the latest included key wins and overrides the other keys. Now, the 'potfile' job definition has two 'before_script' keys. The first occurrence prints out list of installed packages, the second exports env vars. Join them under one key. 1: https://yaml.org/spec/1.2-old/spec.html#id2759572 2: https://docs.gitlab.com/ci/yaml/yaml_optimization/#anchors Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- .gitlab-ci.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e79da09443..04bfef8ed7 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -127,15 +127,14 @@ potfile: NAME: almalinux-9 before_script: - cat /packages.txt - needs: - - job: x86_64-almalinux-9-container - optional: true - rules: - - if: '$CI_PROJECT_NAMESPACE =3D=3D $RUN_UPSTREAM_NAMESPACE && $CI_PIP= ELINE_SOURCE =3D=3D "push" && $CI_COMMIT_BRANCH =3D=3D $CI_DEFAULT_BRANCH' - when: on_success - - when: never - before_script: - *script_variables + needs: + - job: x86_64-almalinux-9-container + optional: true + rules: + - if: '$CI_PROJECT_NAMESPACE =3D=3D $RUN_UPSTREAM_NAMESPACE && $CI_PIP= ELINE_SOURCE =3D=3D "push" && $CI_COMMIT_BRANCH =3D=3D $CI_DEFAULT_BRANCH' + when: on_success + - when: never script: - source ci/jobs.sh - run_potfile --=20 2.54.0