From nobody Tue Dec 16 16:31:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1743166409; cv=none; d=zohomail.com; s=zohoarc; b=YQ9O31e9w7urSdapo/iEv7DdFEGDjcTIqdpCUTk2TMeQgkqDKthipn1U6xPs1DiWeIGzh9+xz2dBMjpB4bGhgrfT91hBXmPGH0Q4K7GCeJ3s25We8Ck+LUuLQhVCRpYX2HVNJq6cTZQOE3kTgjxxaucC1E9aSiBKXfwSA5WRCtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743166409; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=Wb+ai2ru4uGyDc2Ktc6kQTYalyR4qp4/7JVpzynx/HY=; b=UxkKSZWzEpHRvQQ72HeWzYsIrXbllCo6KHJcfGPIC5bSPpgjp4KDo/9U6EIB/IBIGxFKQG1HDLdPrfCN6OhwkH2OPzfm1j9nGnTPOwvPIEkm/g/2A6aQDSVHuO8vsPCuJ50VgG95yGRnsnqkW5wHaDfyRscCfB0HEEEJE6f1xSI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1743166409778938.6666242633551; Fri, 28 Mar 2025 05:53:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D60A21323; Fri, 28 Mar 2025 08:53:28 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6D7E61215; Fri, 28 Mar 2025 08:52:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 417D911FB; Fri, 28 Mar 2025 08:52:43 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 553D211B2 for ; Fri, 28 Mar 2025 08:52:42 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-4G3or7qmMGiZGTPJknuh_w-1; Fri, 28 Mar 2025 08:52:40 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3D781801A12 for ; Fri, 28 Mar 2025 12:52:39 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.8]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B46261828AA7; Fri, 28 Mar 2025 12:52:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743166362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3pfCn4WE9mmj2xDJcsu3Gpla5fZtrUYQuShYK7OOLc=; b=bLgOeOjs8rVGo34/9nvaTsDDiOWj8K1efN3mwkigwYNkMhP0WZr7qiNT2XmCi4SwW925rS CmY1i1ajZfEj6pIRHngi+GV0FbTlIFeSBQrWiLwWPMU9lSIfMKL2WvcgD5Rtew9ezOIhZU NRzx6qRAvDDZ71kJDDPPZZ0smMBwwEc= X-MC-Unique: 4G3or7qmMGiZGTPJknuh_w-1 X-Mimecast-MFC-AGG-ID: 4G3or7qmMGiZGTPJknuh_w_1743166359 To: devel@lists.libvirt.org Subject: [PATCH 1/8] virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable Date: Fri, 28 Mar 2025 13:52:27 +0100 Message-ID: <04b6e74316e191e84f5793622391e63ba2952b85.1743166287.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7TFTOV0reO0TxPLhAI639OPE_Hu_3ZYyfoEGKmYJAjM_1743166359 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XELC27HEVQSMZUWI5UBKMPWOEJWQ7VMS X-Message-ID-Hash: XELC27HEVQSMZUWI5UBKMPWOEJWQ7VMS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1743166411927019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Since the refactor to use proper enum type for the network transport the 'transport' variable is no longer filled. Remove it and fix the error message which references it without using NULLSTR. Fixes: 452695926dc Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 99ecb03067..53ab502306 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6017,7 +6017,6 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, virStorageNetHostDef *host) { int ret =3D -1; - g_autofree char *transport =3D NULL; g_autofree char *port =3D NULL; memset(host, 0, sizeof(*host)); @@ -6043,7 +6042,7 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket !=3D NULL) { virReportError(VIR_ERR_XML_ERROR, _("transport '%1$s' does not support socket attribu= te"), - transport); + virStorageNetHostTransportTypeToString(host->transp= ort)); goto cleanup; } --=20 2.49.0