From nobody Sun Apr 28 23:11:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623754467; cv=none; d=zohomail.com; s=zohoarc; b=Cs6PETQ7KOJtWXaBh4bYUb8b4VEWUGJfziBwvSaHUdRRtQ7sHB+3iuUPAXi2dYsN92VH0lXAOoZ5ez6vdg3nVGxhXpvMXboLJif/g+6WyS2fTUZG5miFWTcF3NbxOEEc3yotcQaqOC45DdlF3j/BbyNkiHrkJTDz6Hwv9b74rx8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623754467; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=hb7ba7rgdlFfC+9LrSTpudDPa9Ln7Ll3RW6xrc8qRVg=; b=jxf/sLbmXrLiQsYK0I8pBey34saUmszPbgoQOxSeAeQULACi3ggLVMR5zBMtXombw6Y2doOsMSZItZODbkg3pYPAxattxb9yPPZVZxR3QGpbOW4YEmqekBamILQ365D1owWik3CdLDNizOkMzttUGnGsCEcRHnL2Qe08ZzR2XPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623754466962482.9676726020467; Tue, 15 Jun 2021 03:54:26 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-ZKsExTncPBmcv0xS432Jeg-1; Tue, 15 Jun 2021 06:54:24 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D69C100C663; Tue, 15 Jun 2021 10:54:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE12260C0F; Tue, 15 Jun 2021 10:54:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3C3024ED7A; Tue, 15 Jun 2021 10:54:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15FAsAML021930 for ; Tue, 15 Jun 2021 06:54:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id B24E660622; Tue, 15 Jun 2021 10:54:10 +0000 (UTC) Received: from cjohnson.localdomain (unknown [10.40.195.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87ADB60C03 for ; Tue, 15 Jun 2021 10:54:07 +0000 (UTC) Received: from cjohnson.redhat.com (cjohnson.k8r.cz [127.0.0.1]) by cjohnson.localdomain (Postfix) with ESMTP id 969A2D87CE4 for ; Tue, 15 Jun 2021 12:42:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623754466; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hb7ba7rgdlFfC+9LrSTpudDPa9Ln7Ll3RW6xrc8qRVg=; b=df19GjNKgnJfPO75ycZdUYaQQ3XgLBqX4WAfNKMiBUOfQ2NFFEV7QwvFsUSQkl+KdX+4xv 9jZXBqFhBVvlnqCOJb+hTEy+uTvP7lyHQXzxwcAmY5YZ0RwL/2HMhD3o+dpcopfArd4x7/ Qjk5OAwtY6IaHtEE3xAkRYObHac2hEg= X-MC-Unique: ZKsExTncPBmcv0xS432Jeg-1 From: Martin Kletzander To: libvir-list@redhat.com Subject: [PATCH] syntax-check: Only prohibit empty first lines in non-empty files Date: Tue, 15 Jun 2021 12:42:30 +0200 Message-Id: <03be57befd07aabc9f07824eaaa76b6883ac6e68.1623753750.git.mkletzan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Martin Kletzander Reviewed-by: J=C3=A1n Tomko --- build-aux/syntax-check.mk | 5 +++-- src/esx/README | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 1037d10cd279..eda89f40add3 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -978,7 +978,8 @@ sc_require_locale_h: =20 sc_prohibit_empty_first_line: @$(VC_LIST_EXCEPT) | xargs awk 'BEGIN { fail=3D0; } \ - FNR =3D=3D 1 { if ($$0 =3D=3D "") { print FILENAME ":1:"; fail=3D1; } } \ + FNR =3D=3D 1 { maybe_fail =3D $$0 =3D=3D ""; } \ + FNR =3D=3D 2 { if (maybe_fail =3D=3D 1) { print FILENAME ":1:"; fail=3D1;= } } \ END { if (fail =3D=3D 1) { \ print "$(ME): Prohibited empty first line" > "/dev/stderr"; \ } exit fail; }' @@ -1835,7 +1836,7 @@ exclude_file_name_regexp--sc_prohibit_mixed_case_abbr= eviations =3D \ ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.= c)$$ =20 exclude_file_name_regexp--sc_prohibit_empty_first_line =3D \ - ^(src/esx/README|tests/(vmwarever|virhostcpu|vircaps2xml)data/.*)$$ + ^tests/vmwareverdata/fusion-5.0.3.txt$$ =20 exclude_file_name_regexp--sc_prohibit_useless_translation =3D \ ^tests/virpolkittest.c diff --git a/src/esx/README b/src/esx/README index 372227cc9c76..cc52d9e3282a 100644 --- a/src/esx/README +++ b/src/esx/README @@ -1,4 +1,3 @@ - Some links to relevant documentation =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.31.1