From nobody Sat Dec 21 14:32:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1725374266864410.94275270471996; Tue, 3 Sep 2024 07:37:46 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C9E9013E1; Tue, 3 Sep 2024 10:37:45 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A5C061412; Tue, 3 Sep 2024 10:36:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4489F1211; Tue, 3 Sep 2024 10:36:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E01BD11ED for ; Tue, 3 Sep 2024 10:36:35 -0400 (EDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-Qa92AQ-BMZieui1fpPGxGA-1; Tue, 03 Sep 2024 10:36:34 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42c7bc97425so15327675e9.1 for ; Tue, 03 Sep 2024 07:36:34 -0700 (PDT) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bbc36bd88sm145317925e9.24.2024.09.03.07.36.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 07:36:31 -0700 (PDT) Received: from wheatley.brq.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 23ADE1FC90BA for ; Tue, 03 Sep 2024 16:36:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725374195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7lQdQZft23EOiwPyEFZP++COpLgKihv3EnesG3KiZXY=; b=hsh6ryqDK3e2EEhX7qLyB8uoI6VIHo+qaLHybpFgFMRimC+olTQWICk34SsWKSnSkU+h/R ynNJ4RBNMVD3QjHZeOMm7YVeOfTb5OolouyH6/LVVoaSXZZgHenuE8zIaRePE9IYZlcEIy EVRF/HZTf6NG2x9+PUlS0Kqkur0uD7g= X-MC-Unique: Qa92AQ-BMZieui1fpPGxGA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725374193; x=1725978993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7lQdQZft23EOiwPyEFZP++COpLgKihv3EnesG3KiZXY=; b=v1D1+rPbSXaPv4j778bqr2mT+p4+s+qGYm1wcxangegn81+3+spStw83Nus0H5w5JB iZ04yyKu4nE6F7r75hPOrqLnRMHBJocWPlRPPeFqNU2JQtvVE0DkgKWLBEXK40d9/F37 fYz53YHFJf7+qJ0z+ZzRyfoy1bhQSNj19r34FmcaaUHMvGQmwJ5k8g0HurWkv8HjUJ0V 0Q5EtGxnXHWpcCgQiW4xM8aoMxdOLJBkeGgSgrs++cu1+/fjvpMWswFlcRZ3E+LGqTaW H/0EAgtuIdlpp/mqPjgWKzWoctLWelnj88lm34NHQ71WjR8hcgdDCZ3u4OsHM+ywqLSA au2Q== X-Gm-Message-State: AOJu0YxTbCqmQ5pAa8OoApYPmPPO4C4NYhf8taK9eO0l+DfFluvGWMTZ Ugi2sZkpCFovkY3ES14WObVdamxa/JX9Yrxm7qSRkVu7luMxa1/GEHgqEAfRkSPkPqdBA17yPiQ xrMnLgbgoWyEShuVMVeX4bauFyRO5q2T1m9P4EnXvMF0M5MQqwic7VaTyKL43VqOu8n7J9/TeTi /nnStfgYTyPw4Qml4XflRWRRyj2q4am01UVhpuLIM= X-Received: by 2002:a05:600c:3110:b0:428:6ac:426e with SMTP id 5b1f17b1804b1-42bb4c4c3famr108139595e9.5.1725374193069; Tue, 03 Sep 2024 07:36:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdInOqJkl5kFRVckYJruyxPTZCc4oNYaXU1pc7Pi2O4oCZKJNOTil/q3bQGKXi5g0KrxOJnw== X-Received: by 2002:a05:600c:3110:b0:428:6ac:426e with SMTP id 5b1f17b1804b1-42bb4c4c3famr108139255e9.5.1725374192181; Tue, 03 Sep 2024 07:36:32 -0700 (PDT) From: Martin Kletzander To: devel@lists.libvirt.org Subject: [PATCH 2/8] network: Do not call virNetworkObjUnsetDefTransient on start cleanup Date: Tue, 3 Sep 2024 16:36:21 +0200 Message-ID: <03b3cb317750e1cb4e2cbb5a2d9da876cac6a99d.1725373964.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 247W5KPE4MHCKRHBZOKCDEQ3IBEQY7LN X-Message-ID-Hash: 247W5KPE4MHCKRHBZOKCDEQ3IBEQY7LN X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1725374268113116600 Content-Type: text/plain; charset="utf-8"; x-default="true" The function networkShutdownNetwork already does that. Signed-off-by: Martin Kletzander Reviewed-by: Laine Stump --- src/network/bridge_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5b510a222cd2..b16d524aa181 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2387,7 +2387,6 @@ networkStartNetwork(virNetworkDriverState *driver, virErrorPtr save_err; =20 virErrorPreserveLast(&save_err); - virNetworkObjUnsetDefTransient(obj); networkShutdownNetwork(driver, obj); virErrorRestore(&save_err); } --=20 2.46.0