From nobody Mon Feb 9 10:33:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659444730; cv=none; d=zohomail.com; s=zohoarc; b=NYMd5BELsiV9LUJ9iauVMjBuurRT6wnU4Osi//Si61exJBOfVRUFWdlHbXOH8J7G9e8MRqTeerqyKzS1NKRPzefQDS4Vkzs3nr39UwSZmomuC9rSgQdz39cTO3tOaofAzkcgf8usICf3NpHNoEjBp4RPlSvhrs2hL3sHrvmDEMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659444730; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nJg47SJLOSrFEqv6iEKWnutAJvXqUWK8S8VE/jJUHeg=; b=fbAt0aXDRcQjaX3Wb9BvWAdygaH1zvOS7s1pTWxkRfBXxFdN3QYv7hv45IZ6I0MwuqB7M//eAwLgo4lc5q18fN0YI2SKtAP8IG5dBd2+BoR//PMXg9WfRaVlOabjlME9EMrnUOYHU0cAMLROVjN/qFynOfiZAY/tgX40qhwsdKA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1659444730711479.970498705766; Tue, 2 Aug 2022 05:52:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-4JAblxwqPtubUmzutgv96g-1; Tue, 02 Aug 2022 08:51:57 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E670518A652A; Tue, 2 Aug 2022 12:51:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D43F4C2812B; Tue, 2 Aug 2022 12:51:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AA2591946A64; Tue, 2 Aug 2022 12:51:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D5DF31946A5E for ; Tue, 2 Aug 2022 12:51:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BF5EA492C3B; Tue, 2 Aug 2022 12:51:53 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46F60492CA5 for ; Tue, 2 Aug 2022 12:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659444728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nJg47SJLOSrFEqv6iEKWnutAJvXqUWK8S8VE/jJUHeg=; b=YjfpP6Gnsxzz61vrFxekIiEu/NTGI28bU7MUZtAlS3i1z+W9GdRewWL8J75vqGBvN0PNii rJb/+xVyBmZalU92/sr32oQKtsLg3n5vN9+wFQm1ztJriwUL7E/Ci/+3lhhLnnwmvuNx1x xQwmm/4xU4KVQx61rWbLWTEgYubCa1w= X-MC-Unique: 4JAblxwqPtubUmzutgv96g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 4/6] qemuProcessQMPConnectMonitor: Connect to probing monitor with 'retry' set to false Date: Tue, 2 Aug 2022 14:51:46 +0200 Message-Id: <02253b8aa14605b2d0ed976f252c9c0c736af1b0.1659444625.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659444731369100009 Content-Type: text/plain; charset="utf-8" In 'qemuProcessQMPLaunch' qemu is very specifically launched using it's internal '-daemonize' flag (see comment in the function) to ensure that the monitor socket is ready and opened prior to attempting the monitor connection. This means we don't have to retry the connection to the monitor in qemuMonitorOpen as the socket will be already there. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1cd55fe989..c51d704af8 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -9493,7 +9493,7 @@ qemuProcessQMPConnectMonitor(qemuProcessQMP *proc) proc->vm->pid =3D proc->pid; - if (!(proc->mon =3D qemuMonitorOpen(proc->vm, &monConfig, true, + if (!(proc->mon =3D qemuMonitorOpen(proc->vm, &monConfig, false, virEventThreadGetContext(proc->event= Thread), &callbacks))) return -1; --=20 2.36.1