From nobody Sun Feb 8 19:57:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606999085; cv=none; d=zohomail.com; s=zohoarc; b=QoMAI8IMG+dJFDOXZ44GEfxckiW5CVyRCVNrkHWtU2UMn5maeBhDfdjhXGFLoQ/u4tugnBqij8CUrsBXCzggMb6w1358DmVSfzKe1FhoTjzImsP9fw7zLrcEgtZBhdVkPZWlAH87DhDaW4jq4AT5EeR2WR1k2yRbMOaftVmkZ/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606999085; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3Ejv+2jBlDGXguCawX2RHc44WEtmuRUQzRyta26ev9Y=; b=LDrwB4czOKQ6HE5Y2deiOKfnQwh58JpZurO4qWp7PH7BHfHr7dK4ASM5b/hGMMO1+PGWKV6Gl43V4/T+P2np5bp4/SVJrN4blvTcFvfi9N5GTONtv92jmiX4uFgqYm+6ycX00T4SYs3BbY0m4jI8TgIh1403yVGayDrRf/picVA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1606999085936842.3134093764365; Thu, 3 Dec 2020 04:38:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-tOIrU74-PYKo1-nH3gqTMw-1; Thu, 03 Dec 2020 07:37:06 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4585D1005E62; Thu, 3 Dec 2020 12:36:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 250A860854; Thu, 3 Dec 2020 12:36:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E6BB21809CA2; Thu, 3 Dec 2020 12:36:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B3CajfM002921 for ; Thu, 3 Dec 2020 07:36:45 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4DC1B5C1BD; Thu, 3 Dec 2020 12:36:45 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id C384D5C1B4 for ; Thu, 3 Dec 2020 12:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606999084; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3Ejv+2jBlDGXguCawX2RHc44WEtmuRUQzRyta26ev9Y=; b=hHqRyOwU5In/NiH8BdKwM1NUCqWgBn7AFmzP3HR5eTQ2Arburr8axsny0c9OP5FD9zHZun yYDZ/0n/OY/SIo5nDlbc22rOWh87zMhcQpzxrx9xqpU462qvP9sOlmIobQVJSfgC0O5Uen y3a4Tchkl7yGDAcBFdZzR2rNxLxzSho= X-MC-Unique: tOIrU74-PYKo1-nH3gqTMw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 04/27] domain_conf: Check NVDIMM UUID in ABI stability Date: Thu, 3 Dec 2020 13:36:07 +0100 Message-Id: <0205195f080f32b23728b02a72d50fcb1cc36bec.1606998426.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The UUID is guest visible and thus shouldn't change if we want to not break guest ABI. Fixes: 08ed673901bb5b4f419b37bcce9b11d31ce370e6 Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 425e3c3710..d8df18b542 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -24204,6 +24204,12 @@ virDomainMemoryDefCheckABIStability(virDomainMemor= yDefPtr src, "source NVDIMM readonly flag")); return false; } + + if (memcmp(src->uuid, dst->uuid, VIR_UUID_BUFLEN) !=3D 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Target NVDIMM UUID doesn't match source NVDI= MM")); + return false; + } } =20 return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info); --=20 2.26.2